PipedreamHQ / pipedream

Connect APIs, remarkably fast. Free for developers.
https://pipedream.com
Other
8.32k stars 5.27k forks source link

Action salesforce new actions #2764

Closed bush4u closed 1 year ago

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
pipedream-docs ✅ Ready (Inspect) Visit Preview Jun 15, 2022 at 3:21PM (UTC)
pipedream-docs-redirect-do-not-edit ✅ Ready (Inspect) Visit Preview Jun 15, 2022 at 3:21PM (UTC)
dylburger commented 2 years ago

Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:

vellames commented 1 year ago

@dannyroosevelt @dylburger There is something strange here. I can see you commit historic, but when I click on the File changed tab looks like the file was not changed, when I try to open the branch source on Github the file is not changed as well. What I am doing wrong here?

For example. I can see this commit, but looks like it does not changed here

dannyroosevelt commented 1 year ago

Hm I'm not sure -- can you ask in one of the dev channels? Maybe another dev has run into this.

vellames commented 1 year ago

Hm I'm not sure -- can you ask in one of the dev channels? Maybe another dev has run into this.

@js07 @jcortes @michelle0927 @andrewjschuang you guys have some idea why I can't see the newest version on Files Changed? Can you guys see the modified version?

michelle0927 commented 1 year ago

@vellames-turing I think the changes from that commit (https://github.com/PipedreamHQ/pipedream/pull/2764/commits/0e24e8ded712da4a1c38c0994c87e29c22c91d97) were reverted in this commit - https://github.com/PipedreamHQ/pipedream/pull/2764/commits/93997ca7b835edd43f8cf524b47201f018cad744

vellames commented 1 year ago

@vellames-turing I think the changes from that commit (0e24e8d) were reverted in this commit - 93997ca

Hummm, indeed, thank you. So it is all working haha @bush4u Can you take a look here? The newest version of your code does not have the suggestions

bush4u commented 1 year ago

@vellames-turing Please help me understand what is going on.

There was a time I rebased from @andrewjschuang branch. Could the be an issue.

DilanAthukorala commented 1 year ago

@bush4u

Observing the following error when deploying components image

bush4u commented 1 year ago

I am checking this

bush4u commented 1 year ago

This happened as a result of destructuring lodash as advised by PR reviewer. I will revert now

andrewjschuang commented 1 year ago

This happened as a result of destructuring lodash as advised by PR reviewer. I will revert now

@bush4u to be able to destructure lodash you can use lodash-es package instead of lodash

DilanAthukorala commented 1 year ago

@bush4u any update on this? if changes are still pending please move this to 'changes required' column.

DilanAthukorala commented 1 year ago

@bush4u I am observing this issue when trying to connect to salesforce account

`Pipedream failed to connect to your account.

Please reach out to integration-errors@pipedream.com and provide this error ID: 13d2c7c558604fe4ba1b714317edc5ce`

image

https://api.pipedream.com/connect/oauth/oa_GXxiEz/callback?code=aPrx_yTkbIprMMgkbmJbDgWOIri4dEn0weuDQEKFTJdhcBCJvvrChUTTOFa0WP09JV5.AQUfSA%3D%3D&state=dV9xbGhwRURMfDMyYjg5ZDY5NTNmZDg1MjgwM2M3ODBkMTg5NWM2OGM3

dannyroosevelt commented 1 year ago

13d2c7c558604fe4ba1b714317edc5ce

@DilanAthukorala that error is not related to the components -- that's related to your Salesforce account:

[
  {
    "message": "The REST API is not enabled for this Organization.",
    "errorCode": "API_DISABLED_FOR_ORG"
  }
]
DilanAthukorala commented 1 year ago

@bush4u I have verified all actions, and there were some issues. Please kindly check the document attached here for the details on these issues. I think mostly some params are not supported for specific API versions and I have mentioned them in the doc. But I didn't check all the params in all actions since it would take a lot of time because there are so many. But you can get an idea of what type of params are causing these issues and do the needful for all actions mainly for - create / update actions. Please let me know if you have any queries.

Issue Report

bush4u commented 1 year ago

Report

I am checking it out

bush4u commented 1 year ago

In Create Campaign Action Observing the following errors when passing values for each of these props My finding on this image

bush4u commented 1 year ago

@andrewjschuang Please, I need your help is needed here. The ParentCampaign and CurrencyIsoField are both valid fields but they are being reported to be non-existing from the endpoint error.

From the API documentation, these fields two are valid.

image

andrewjschuang commented 1 year ago

@andrewjschuang Please, I need your help is needed here. The ParentCampaign and CurrencyIsoField are both valid fields but they are being reported to be non-existing from the endpoint error.

From the API documentation, these fields two are valid.

I would say discard both parameters. ParentId seems to substitute ParentCampaign.

bush4u commented 1 year ago

@andrewjschuang

Looking at the logs, there are lots of situations like this. https://docs.google.com/document/d/1_uFlKVhHL2zpi1hiIOv0aAjLogLIhg1TniL81avv1xk/edit

vunguyenhung commented 1 year ago

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information Salesforce_1474.pdf

bush4u commented 1 year ago

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information Salesforce_1474.pdf

Okay. Checking...

vunguyenhung commented 1 year ago

Hi everyone, all test cases are passed! Ready for release!

Test report Salesforce_1474_2244.pdf


For the suggested improvement, I will create another issue to track.

bush4u commented 1 year ago

/approve