Solving #2870, Adding parameter to filter for trashed folders

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
pipedream-docs	✅ Ready (Inspect)	Visit Preview	Jun 9, 2022 at 2:16PM (UTC)
pipedream-docs-redirect-do-not-edit	✅ Ready (Inspect)	Visit Preview	Jun 9, 2022 at 2:16PM (UTC)

[dylburger]

Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:

• [ ] Create components to address specific use cases whenever possible
• [ ] Component keys should follow the format app_name_slug-slugified-component-name
• [ ] Components should follow the standard directory structure
• [ ] Prefer Node.js client libraries to REST APIs
• [ ] When making API requests, handle pagination to ensure all data / events are processed
• [ ] Use secret props to capture sensitive data
• [ ] Props and methods should be defined in app files whenever possible
• [ ] Document methods with JS Docs
• [ ] Use optional props whenever possible, and set a default value where you can
• [ ] Use async options to accept user input wherever possible

[dylburger]

Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified.

[dannyroosevelt]

@bsommardahl do you want to wrap this up and implement the suggested changes, or do you want one of our devs to finish up the remaining work?

[bsommardahl]

I'll make sure it gets done tomorrow. Thanks for the nudge.

On Tue, May 24, 2022, 6:42 PM Danny Roosevelt @.***> wrote:

@bsommardahl https://github.com/bsommardahl do you want to wrap this up and implement the suggested changes, or do you want one of our devs to finish up the remaining work?

— Reply to this email directly, view it on GitHub https://github.com/PipedreamHQ/pipedream/pull/2871#issuecomment-1136536038, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB2L335SFDZUPYEREBI3HLVLVSOZANCNFSM5WFAWORQ . You are receiving this because you were mentioned.Message ID: @.***>

[dannyroosevelt]

I'll make sure it gets done tomorrow. Thanks for the nudge. … On Tue, May 24, 2022, 6:42 PM Danny Roosevelt @.> wrote: @bsommardahl https://github.com/bsommardahl do you want to wrap this up and implement the suggested changes, or do you want one of our devs to finish up the remaining work? — Reply to this email directly, view it on GitHub <#2871 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB2L335SFDZUPYEREBI3HLVLVSOZANCNFSM5WFAWORQ . You are receiving this because you were mentioned.Message ID: @.>

Sounds good!

[dylburger]

@bsommardahl I just wanted to check in on this. Do you still want to wrap these changes up, or would it be easier for us to make the updates?

[bsommardahl]

Well, there was my hope and there was reality. Maybe better if you finish it up for me. Sorry, I have gotten busy again.

On Mon, Jun 6, 2022 at 6:12 PM Dylan J. Sather @.***> wrote:

@bsommardahl https://github.com/bsommardahl I just wanted to check in on this. Do you still want to wrap these changes up, or would it be easier for us to make the updates?

— Reply to this email directly, view it on GitHub https://github.com/PipedreamHQ/pipedream/pull/2871#issuecomment-1148021806, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB2L37IW6IC2RMULRV5LFDVN2AV3ANCNFSM5WFAWORQ . You are receiving this because you were mentioned.Message ID: @.***>

[dannyroosevelt]

Well, there was my hope and there was reality. Maybe better if you finish it up for me. Sorry, I have gotten busy again. … On Mon, Jun 6, 2022 at 6:12 PM Dylan J. Sather @.> wrote: @bsommardahl https://github.com/bsommardahl I just wanted to check in on this. Do you still want to wrap these changes up, or would it be easier for us to make the updates? — Reply to this email directly, view it on GitHub <#2871 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB2L37IW6IC2RMULRV5LFDVN2AV3ANCNFSM5WFAWORQ . You are receiving this because you were mentioned.Message ID: @.>

No problem at all! Thank you for the original contribution!

@andrewjschuang can you implement your suggested changes?

[andrewjschuang]

Ready for QA

[DilanAthukorala]

@andrewjschuang @dannyroosevelt If we set trashed = true this will return only the folders in trash. It won't return folders that are not in trash. So if this is the behavior of the API then the name and description here saying 'include trash' is misleading. And should we set the default value as false ?

[andrewjschuang]

@andrewjschuang @dannyroosevelt If we set trashed = true this will return only the folders in trash. It won't return folders that are not in trash. So if this is the behavior of the API then the name and description here saying 'include trash' is misleading. And should we set the default value as false ?

@DilanAthukorala So let me check if I understand correctly.

1. If the parameter is not sent, it will return all folders including those in trash.
2. If trashed = true, it will return only those in trash
3. If trashed = false, it will return only those not in trash

We could keep the name/description and change the behaviour of the action.

true -> 1. false -> 3.

[DilanAthukorala]

@andrewjschuang @dannyroosevelt If we set trashed = true this will return only the folders in trash. It won't return folders that are not in trash. So if this is the behavior of the API then the name and description here saying 'include trash' is misleading. And should we set the default value as false ?

@DilanAthukorala So let me check if I understand correctly.

1. If the parameter is not sent, it will return all folders including those in trash.

2. If `trashed = true`, it will return only those in trash

3. If `trashed = false`, it will return only those **not** in trash

We could keep the name/description and change the behaviour of the action.

true -> 1. false -> 3.

@andrewjschuang Yes we could make trashed param optional and not send it by default. But again I think the description implies that setting trashed=true means it includes trashed folders along with the other folders (not trashed) which is not the actual behavior of that param.

[DilanAthukorala]

Verification completed.

[dannyroosevelt]

This is ready for release!

[andrewjschuang]

/approve