rocket reach action

[Jordon-L]

The props are all labeled as optional because the endpoints allow for multiple different parameters. For lookup profile specifically, inputting only the name prop or only the current employer prop will result in an error, and Rocket Reach API will ask for more information. I have put in if statements to notify the user if one of these scenarios happens.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
pipedream-docs	✅ Ready (Inspect)	Visit Preview	Jun 9, 2022 at 0:12AM (UTC)
pipedream-docs-redirect-do-not-edit	✅ Ready (Inspect)	Visit Preview	Jun 9, 2022 at 0:12AM (UTC)

[dylburger]

Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:

• [ ] Create components to address specific use cases whenever possible
• [ ] Component keys should follow the format app_name_slug-slugified-component-name
• [ ] Components should follow the standard directory structure
• [ ] Prefer Node.js client libraries to REST APIs
• [ ] When making API requests, handle pagination to ensure all data / events are processed
• [ ] Use secret props to capture sensitive data
• [ ] Props and methods should be defined in app files whenever possible
• [ ] Document methods with JS Docs
• [ ] Use optional props whenever possible, and set a default value where you can
• [ ] Use async options to accept user input wherever possible

[Jordon-L]

fixes #2461

[dylburger]

Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified.

[Jordon-L]

I don't have any package files. Would doing an npm init then following the format of the package files for figma be good?

[Jordon-L]

Do you need the package-lock.json too? My npm version is 8.10.0. Is there going to be a compatibility issue?

[Jordon-L]

I have installed an older version of npm. my package files look the same as figma's package files now.

[Jordon-L]

Hi, I have added the suggestions. Let me know if I am missing anything or need to change anything.

[Jordon-L]

@lcaresia Thank you for the feedback. I have applied all the suggestions.

[Jordon-L]

I am failing some pull request checks, Is there a problem with the code I submitted? This was not happening 2 weeks ago.

[dylburger]

@Jordon-L you'll want to update your fork with the latest master branch of the pipedream repo, then run:

git fetch origin
git merge origin/master

# from repo root
npm ci
npx pnpm install -r
git add pnpm-lock.yaml
git commit
git push

The error just means that the lock file for pnpm is out-of-date, and you need to pull in the latest changes.

[Jordon-L]

When I run npx pnpm install -r, I get an error  ERR_PNPM_PEER_DEP_ISSUES  Unmet peer dependencies. Should I be concerned?

[dylburger]

When I run npx pnpm install -r, I get an error  ERR_PNPM_PEER_DEP_ISSUES  Unmet peer dependencies. Should I be concerned?

No, that's fine. In the main repo we have a new .npmrc file that skips that check:

❯ cat .npmrc
auto-install-peers=true

[dylburger]

@Jordon-L I reviewed all of your most-recent code and approved the changes. Merging them now.

[dylburger]

Looks like they published successfully!

[Jordon-L]

@dylburger Thank you for the feedback and help regarding the pull request check errors.