feat: BingX API interface complete :)

[trendoscope-algorithms]

Initial action getBalance implemented and tested.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
pipedream-docs	✅ Ready (Inspect)	Visit Preview	Oct 6, 2022 at 1:52PM (UTC)
pipedream-docs-redirect-do-not-edit	✅ Ready (Inspect)	Visit Preview	Oct 6, 2022 at 1:52PM (UTC)

[dylburger]

Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified.

[dylburger]

Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:

• [ ] Create components to address specific use cases whenever possible
• [ ] Component keys should follow the format app_name_slug-slugified-component-name
• [ ] Components should follow the standard directory structure
• [ ] Prefer Node.js client libraries to REST APIs
• [ ] When making API requests, handle pagination to ensure all data / events are processed
• [ ] Use secret props to capture sensitive data
• [ ] Props and methods should be defined in app files whenever possible
• [ ] Document methods with JS Docs
• [ ] Use optional props whenever possible, and set a default value where you can
• [ ] Use async options to accept user input wherever possible

[trendoscope-algorithms]

Updated tests.

Get Balance:

Get Positions:

[vellames]

@trendoscope-algorithms Is this PR still in draft?

[trendoscope-algorithms]

@trendoscope-algorithms Is this PR still in draft?

Just one more round of test and will update it :) thanks @vellames for your help throughout. Really good suggestions on moving common block to app.

[trendoscope-algorithms]

Tests.

Account GetBalance:

Account GetPositions:

Market GetAllContracts

Market GetCurrentFunding

Market GetHistoricalFunding

Market GetKLine

Market GetLatestPrice

Market GetMarketDepth

Market GetMarketTrades

I will not be testing trades one now as it will need money for trading. Will do that later. But, feel free to do it from your side :)

[trendoscope-algorithms]

Looks like there is one more issue. I am unable to typify numberical values. There is integer. But, I am unable to use float, double, number for floating point values. Any suggestions?

Also, is it possible to add a date picker type?

[trendoscope-algorithms]

Looks like there is one more issue. I am unable to typify numberical values. There is integer. But, I am unable to use float, double, number for floating point values. Any suggestions?

Solved. And ready to be merged :)

[trendoscope-algorithms]

Hi @trendoscope-algorithms, I was going to push to your repo but it seems that I won't be able to test all. Can you please follow this folder structure? And then let's merge this. Thank you very much.

Done.

[trendoscope-algorithms]

Hi @feyzullah , @vellames - the request is still showing changes required. Wonder if it is also expecting @vellames to approve as he requested changes earlier. Can you please check this?

[trendoscope-algorithms]

thanks @feyzullah :)

[feyzullah]

@trendoscope-algorithms it is done. Now QA team will review :)

[vunguyenhung]

Hello @trendoscope-algorithms, I have tested this PR and there're 2 test cases failed. Thank you so much for your contribution!

Please check the test report below for more information BingX_4381_2239.pdf

[trendoscope-algorithms]

Hello @trendoscope-algorithms, I have tested this PR and there're 2 test cases failed. Thank you so much for your contribution!

Hi @vunguyenhung ,

It is working fine for me.

The getbalance and other trade related operations are done on perpetual future account and not spot account. It may be possible that you have not enabled this type of account? Usually they are not enabled due to high risk nature.

Can you check once?

[vunguyenhung]

Hello @trendoscope-algorithms, thank you for replying! I understand that users having spot and future account enabled will not got the error. Though there might be other users that just like me, and showing them error is not really user friendly. Is it possible to catch the error and still show data in this case?

[trendoscope-algorithms]

Hello @trendoscope-algorithms, thank you for replying! I understand that users having spot and future account enabled will not got the error. Though there might be other users that just like me, and showing them error is not really user friendly. Is it possible to catch the error and still show data in this case?

Thanks @vunguyenhung I have updated code to show the error message received from the API.

It will be the same error for both as both issues came from getBalance() failure in case if there is no futures account.

[vunguyenhung]

Hi everyone, I have added some commits to improve this and confirm that all test cases are passed!

Test report BingX_4381.pdf

[vunguyenhung]

I will merge this on behave of @trendoscope-algorithms!

[vunguyenhung]

/approve

[trendoscope-algorithms]

Awesome. Thanks very much guys - @vellames , @feyzullah , @vunguyenhung

[gilusgit]

Hey, I suggested with other BingX events and created event for Spot but somethings is wrong with it. I'm not very good at coding. Can someone help?

import bingx from "../../bingx.app.mjs";

export default { name: "BingX Trade New Spot Order", version: "0.0.3", key: "bingx-trade-new-spot-order", description: "Place a New Spot Order .", props: { bingx, symbol: { propDefinition: [ bingx, "symbol", ], }, side: { propDefinition: [ bingx, "side", ], }, type: { propDefinition: [ bingx, "type", ], }, quoteOrderQty: { propDefinition: [ bingx, "quoteOrderQty", ], }, quantity: { propDefinition: [ bingx, "quantity", ], }, }, type: "action", async run({ $ }) { const API_METHOD = "POST"; const API_PATH = "/openApi/spot/v1/trade/order"; const parameters = { "symbol": this.symbol, "side": this.side, "quoteOrderQty": this.bingx.convertToFloat(this.quoteOrderQty), "quantity": this.bingx.convertToFloat(this.quantity), "type": this.type, }; const returnValue = await this.bingx.makeRequest(API_METHOD, API_PATH, parameters); $.export("$summary", New Spot Order for ${this.symbol}); return returnValue; }, };

[gilusgit]

it shows error like this:

Code Error Cannot find module '/tmp/bingx.app.mjs' Require stack: - /var/task/src/index.js - /var/runtime/UserFunction.js - /var/runtime/Runtime.js - /var/runtime/index.js

[abbasazad]

new address for bingx from 30/11/2023 from api-swap-rest.bingbon.pro to api-swap-rest.bingx.com