search

PipedreamHQ / pipedream

Connect APIs, remarkably fast. Free for developers.
https://pipedream.com
Other
8.3k stars 5.26k forks source link

[COMPONENTS] Facebook Lead Ads #6907

Open malexanderlim opened 10 months ago

malexanderlim commented 10 months ago

Describe the event source. What app is this for, and what event does the trigger correspond to? Facebook Lead Ads

Triggers

Actions

Please provide a link to the relevant API docs for the specific service / operation this trigger is tied to. https://developers.facebook.com/docs/marketing-api/guides/lead-ads/setup

vellames commented 10 months ago

Blocked due to app problem. Please check this link for more context https://pipedream-users.slack.com/archives/G01J50YGJGP/p1688416023313869 Cc: @dannyroosevelt @dylburger

malexanderlim commented 10 months ago

Unblocked via:

  1. Additional permissions
  2. Setting app to live.
  3. Going through GDPR review for Facebook Lead Ads app.
vunguyenhung commented 9 months ago

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information https://vunguyenhung.notion.site/COMPONENTS-Facebook-Lead-Ads-6907-7c5d6faa203343a78846a0b4bb88524e

vellames commented 9 months ago

Hey @vunguyenhung . Sorry for not giving you context. We are currently waiting for Facebook to liberate some scopes of this app. I tagged you in slack for more details

vunguyenhung commented 9 months ago

Hi @vellames, could you please check the test report? Those failed test cases are not related to Facebook scopes

vunguyenhung commented 9 months ago

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information https://vunguyenhung.notion.site/COMPONENTS-Facebook-Lead-Ads-6907-7c5d6faa203343a78846a0b4bb88524e

vellames commented 9 months ago

Changes applied

vunguyenhung commented 9 months ago

Hi @malexanderlim, I checked the components here and they're good per the props and names. But I couldn't test the functionalities (that I suspect due to permission issue). Could you help to verify again if it's good?

https://vunguyenhung.notion.site/COMPONENTS-Facebook-Lead-Ads-6907-7c5d6faa203343a78846a0b4bb88524e?pvs=4

vunguyenhung commented 9 months ago

Hi everyone, all test cases are passed! Ready for release!

Test report https://vunguyenhung.notion.site/COMPONENTS-Facebook-Lead-Ads-6907-7c5d6faa203343a78846a0b4bb88524e

vellames commented 9 months ago

Lets wait until Facebook approve our app :)

malexanderlim commented 9 months ago

@vellames , I tried testing this today, and the actions work; however - if there are no leads, I'm getting an error:

Screenshot 2023-07-21 at 5 14 12 PM

With Leads present, both actions appear to work:

Screenshot 2023-07-21 at 5 14 44 PM Screenshot 2023-07-21 at 5 14 29 PM

Can you take a look? Thanks!

malexanderlim commented 9 months ago

In addition, I was not clear on why the Trigger New Lead Submitted has an App Secret prop -- this should be handled via OAuth, right?

vellames commented 9 months ago

Hey @malexanderlim . About empty leads, I think it should be fine now You need to specify the app secret about the trigger to validate the HMAC signature. As far as I understood, The webhook should be installed in the client app. So the client that wants to be aware of any updates needs to create an app and in webhook session specify the URL generated by pipedream

ctrlaltdylan commented 6 months ago

@malexanderlim @vellames have we added support for Facebook Lead Ads? Can I close this issue out or is it still blocked?

malexanderlim commented 6 months ago

We're unfortunately still blocked on verification by Facebook. I will take a look to try to move this forward.

On Fri, Oct 27, 2023 at 7:35 AM Dylan Pierce @.***> wrote:

@malexanderlim https://github.com/malexanderlim @vellames https://github.com/vellames have we added support for Facebook Lead Ads? Can I close this issue out or is it still blocked?

— Reply to this email directly, view it on GitHub https://github.com/PipedreamHQ/pipedream/issues/6907#issuecomment-1783025416, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKBUUHOBNITJK2LPRJSWOJLYBPBEFAVCNFSM6AAAAAAZHCHAVSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBTGAZDKNBRGY . You are receiving this because you were mentioned.Message ID: @.***>

robbp2 commented 6 months ago

Looking forward to having this integration completed.

sergio-eliot-rodriguez commented 2 months ago

User request on " Facebook Leads [APP] #4453 "

Are there specific actions, or triggers, you'd like to see for this app? Please let us know here or use the Action and Trigger issue templates to open requests for each! When a user fills in a Facebook form, the details of the form are captured so I can update that information in to a google sheet

This should be covered by "New Lead Submitted"