search

PipedreamHQ / pipedream

Connect APIs, remarkably fast. Free for developers.
https://pipedream.com
Other
8.8k stars 5.27k forks source link

[Components] Zoho Assist #7414

Closed dannyroosevelt closed 1 year ago

dannyroosevelt commented 1 year ago

App

Zoho Assist https://www.zoho.com/assist/

Actions:

  1. Create session https://www.zoho.com/assist/api/createasession.html
  2. Schedule session https://www.zoho.com/assist/api/schedulesession.html
  3. Get session reports https://www.zoho.com/assist/api/getsessionreports.html
GTFalcao commented 1 year ago

@malexanderlim I get an error related to OAuth scopes when trying to obtain session reports. According to this page it looks like that'd be the ZohoAssist.reportapi.READ scope - and checking the auth window details, indeed it seems we aren't requesting it.

malexanderlim commented 1 year ago

Should be all set here Guilherme!

vunguyenhung commented 1 year ago

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information https://vunguyenhung.notion.site/Components-Zoho-Assist-7414-0ea92706f1424743a5778a21fdde8962

GTFalcao commented 1 year ago

@vunguyenhung in order to infer the UTC Offset from Time Zone we will need to add a list of all timezones as options to this prop, do you agree?

vunguyenhung commented 1 year ago

Hi @GTFalcao, if it's too much effort for you to do that then I'm okay to skip tht improvement 🙏

GTFalcao commented 1 year ago

The exact format specified in their API was a very broad one, but it doesn't seem to be strictly enforced, so I've added a simplified list of timezones as options, and inferred the UTC Offset as you said. Should be easier to use now!

vunguyenhung commented 1 year ago

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information https://vunguyenhung.notion.site/Components-Zoho-Assist-7414-0ea92706f1424743a5778a21fdde8962

GTFalcao commented 1 year ago

@vunguyenhung I cannot reproduce the 'scheduling in the past' issue - I tried several (shortly in the future) dates that worked correctly, including your own exact input, and was able to get this error only when trying actual past timestamps.

As for 'get session reports', looks like it was expecting a different date format than the other action (oddly) - I fixed it to send the dates as unix time integers as expected by the API.

Let me know if you still run into any issues and we can sort it out by comparing our inputs and trying to find what could be causing it.

vunguyenhung commented 1 year ago

Hi everyone, all test cases are passed! Ready for release!

Test report https://vunguyenhung.notion.site/Components-Zoho-Assist-7414-0ea92706f1424743a5778a21fdde8962