PipedreamHQ / pipedream

Connect APIs, remarkably fast. Free for developers.
https://pipedream.com
Other
8.8k stars 5.27k forks source link

[Components] Zoho Expense #7425

Closed dannyroosevelt closed 1 year ago

dannyroosevelt commented 1 year ago

App

Zoho Expense https://www.zoho.com/expense/

Triggers:

  1. Expense Report Submitted: Activate when an expense report submission takes place.
  2. Travel Request Approved: Activate after approval of a travel request.

Actions:

  1. Create Expense: Generate a new expense entry in the Zoho Expense system.
  2. Update Expense Report: Alter details in an existing expense report.
  3. Reject Travel Request: Disapprove a pending travel request in the system.

This list of suggested components was generated using ChatGPT

jcortes commented 1 year ago

Hi @malexanderlim Just to give a heads up. This one is going to be blocked because the three actions don't work due to the following:

In Create Expense and Reject Travel Request Actions

I've got the following error when trying to get Currencies in Create Expense action and when testing the Reject Travel Request action with data

{"code":57,"message":"You are not authorized to perform this operation"}

Endpoints

https://www.zoho.com/expense/api/v1/currencies/#retrieve-list-of-currencies https://www.zoho.com/expense/api/v1/trips/#reject-a-trip-request

In Update Expense Report Action

I've got the following error when testing with data

{"code":37,"message":"The HTTP method PUT is not allowed for the requested resource"}

Endpoints

https://www.zoho.com/expense/api/v1/expense-reports/#update-an-expense-report

malexanderlim commented 1 year ago

Hi @jcortes , can you please retry? I've spoken to Zoho support and they have advised me to add the following scope: ZohoExpense.fullaccess.ALL

vunguyenhung commented 1 year ago

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information https://vunguyenhung.notion.site/Components-Zoho-Expense-7425-eacf3453071e431780b8760862b24772

jcortes commented 1 year ago

Hi @vunguyenhung about

Improvement 1: The expense async prop only should show all expenses

The Expense {index} - Expense ID prop only show the expense that is already added to the report. I think it would make more sense to show all expenses, so that user will be able to add them to their report

You need to make sure the rest of the expenses have been submitted otherwise they won't show up
vunguyenhung commented 1 year ago

Hi everyone, all test cases are passed! Ready for release!

Test report https://vunguyenhung.notion.site/Components-Zoho-Expense-7425-eacf3453071e431780b8760862b24772