Closed LucBerge closed 7 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
pipedream-docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Sep 20, 2023 10:19am |
pipedream-docs-redirect-do-not-edit | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Sep 20, 2023 10:19am |
Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified.
Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:
key
s should follow the format app_name_slug-slugified-component-name
secret
props to capture sensitive dataoptional
props whenever possible, and set a default
value where you canThis is weird how airtable_oauth
refer to airtable
...
Hi @LucBerge,
As I checked your PR, the Airtable app is no longer valid as the image below
Would you mind updating airtable_oauth
instead?
Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.
Please check the test report below for more information https://vunguyenhung.notion.site/Fix-8121-8138-ad2c5bf6919b4828980c4787f3e1ccc5
@vunguyenhung
Would you mind updating airtable_oauth instead?
This is exactly what I have done. The airtable_oauth
component calls the airtable
component in the airtable/common/actions.mjs file.
As I said
This is weird how airtable_oauth refer to airtable...
I think you forgot to create a utils.mjs
and a constants.mjs
files in the airtable_oauth/common/ folder. Then you have no need to import ../../airtable/common.
Hi @LucBerge,
You will need to bump the version of airtable_oauth action to have the new version published, and for me to test the new version. Then I will test the airtable_oauth action instead.
I would urge you to publish and test the action yourself first to reduce the back-and-forth effort.
@vunguyenhung should I create the utils.mjs
and constants.mjs
?
@LucBerge I think your changes are minimal, so you don't need to create new files. You can try to bump the version of airtable_oauth yourself and test your code
@vunguyenhung If I do this and do not create the files, the _Pull Request Checks / Ensure component commits modify component versions (pullrequest) workflow will fail.
Should I increment, the airtable_oauth component versions as well as the airtable components version (already done)? Or the airtable_oauth component versions only?
For futur airtable_oauth
component updates, I would recommend you to add the files and make sure airtable_oauth
does not call airtable
.
@michelle0927 did the migration. Maybe we can ask her?
In this PR, airtable_oauth
and airtable
are now correctly seperated. See: https://github.com/PipedreamHQ/pipedream/pull/8138/commits/400b101f5b07ac7bc509979cfe355c8734a6c641
I did tried the following actions:
It works well for me.
I will merge this on behalf of the user
Hi everyone, all test cases are passed! Ready for release!
Test report https://vunguyenhung.notion.site/Fix-8121-8138-ad2c5bf6919b4828980c4787f3e1ccc5
Thank you all
WHAT
🤖 Generated by Copilot at c653ee4
Remove
FieldType.MULTIPLE_RECORD_LINKS
from Airtable app utils. This simplifies the output schema and value generation logic and prepares for further refactoring.🤖 Generated by Copilot at c653ee4
WHY
Fixing the issue #8121.
HOW
🤖 Generated by Copilot at c653ee4
FieldType.MULTIPLE_RECORD_LINKS
from computed field types for Airtable app (link)