search

PippoRJ / hugo-refresh

MIT License
115 stars 79 forks source link

resize "summaryImage"'s on "All Tags" page #61

Closed Michel69-de closed 3 years ago

Michel69-de commented 3 years ago

I found an issue on the All Tags page. The summary boxes of different tags do have different sizes. is this a bug or a feature?

Refresh-resize-all_tags

PippoRJ commented 3 years ago

Hey @Michel69-de that's definitely not a feature! XD What browser/version are you using? I can see the problem in the android version of Chrome (using "Desktop Site") but not in the desktop version of Chrome..

Michel69-de commented 3 years ago

Win10 Google Chrome Version 89.0.4389.82 (Offizieller Build) (64-Bit)

Opera Version:74.0.3911.203

Microsoft Edge Version 89.0.774.45 (Offizielles Build) (64-Bit)

MacOS Safari Version 14.0.3 (16610.4.3.1.4)

It seems to happen on screen width between 769px-1023px but only on the All Tags page so in my opinion there is something with the usage of the responsive settings.

Michel69-de commented 3 years ago

After some research i found this: Comparing layouts\_default\terms.html with layouts\_default\list.html I found an extra <div></div> container.

layouts\_default\terms.html

12 -   <div class="columns">
32 -   </div>

After removing it looks like its fixed.

PippoRJ commented 3 years ago

Hey @Michel69-de yes, that fixed it! Amazing thanks! If you open a pull request I can attribute the fix to you...!

Michel69-de commented 3 years ago

As I mentioned I'm new to github and don't know much about pull request and stuff like that. My intension is to save other peoples livetime by sharing my recognitions so I would welcome it if you like to share.

PippoRJ commented 3 years ago

yeah that's always welcome!