search

PiranhaCMS / piranha.core

Piranha CMS is the friendly editor-focused CMS for .NET that can be used both as an integrated CMS or as a headless API.
http://piranhacms.org
MIT License
2.02k stars 561 forks source link

Can't upload images after v11 upgrade #2068

Closed patrick-alpcot closed 6 months ago

patrick-alpcot commented 6 months ago

We recently upgraded to .net8 and upgraded Piranha to v11. After the upgrade we were no longer able to upload images in the CMS.

image

We have now rolled back the upgrade, and image upload works again.

tidyui commented 6 months ago

I can't reproduce the error when creating a new site using the v11 version of the templates. Are you sure you updated the package Piranha.ImageSharp as well to v11 since the external ImageSharp library was updated for this version? Also, if you have a direct dependency to ImageSharp in your application you have to make sure that you're using the same version as Piranha.ImageSharp references.

patrick-alpcot commented 6 months ago

Hey! Thanks for the quick reply, I was told that we did, but I'll check with my team and get back to you.

patrick-alpcot commented 6 months ago

We did update the ImageSharp package, and we updated our SixLabors.ImageSharp dependency to 3.1.4... Which is the highest version of 'SixLabors.ImageSharp' we can use?

tidyui commented 6 months ago

Piranha.ImageSharp is compiled using 2.1.3

https://www.nuget.org/packages/Piranha.ImageSharp#dependencies-body-tab

Upgrading the external dependency to 3.x will most likely break.

tidyui commented 6 months ago

Please also remember that if you consume SixLabors.ImageSharp 3.x as a direct dependency in your application you might need to purchase a commercial license. This is also why we choose not to update our ImageSharp package to 3.x, to avoid confusion for consumers of the Piranha packages.

patrick-alpcot commented 6 months ago

Thanks for the info! Good to know about the license too!