Pirate-MIDI / Pirate-MIDI-BridgeOS

Documenting Bugs & Issues - Public Collaboration
10 stars 2 forks source link

When using Go To Bank smart message, message stacks/LEDs in destination bank are triggered/activated #100

Closed frenno closed 1 year ago

frenno commented 1 year ago

Device:

Describe the bug When using Go To Bank smart message, switch states are not reset when entering a new bank, so the same footswitch in the new bank is activated (including associated message stacks/LEDs).

To Reproduce Steps to reproduce the behavior:

  1. Start with a blank template and Bank Change PC messages turned off to eliminate any messages not set up below.

  2. On Bank0/FS1, add the following messages to the specified stacks:

    • Toggle On message (eg. CC 16 127 127)
    • Press message (eg. CC 15 126 126)
    • Release message (eg. CC 14 125 125)
    • Hold message (eg. CC 13 124 124)
    • Hold Release message (eg. CC 12 123 123)
    • Secondary Toggle On (eg. CC 11 122 122)
  3. (a). On Bank1/FS1, add a Toggle On message Go To Bank 0

  4. (a). Navigate to Bank 1 on the device and tap FS1

  1. (b). On Bank1/FS1, delete the Toggle On message and add a Press message Go To Bank 0
  2. (b). Navigate to Bank 1 on the device and tap FS1
  1. (c). On Bank1/FS1, delete the Press message and add a Hold message Go To Bank 0
  2. (c). Navigate to Bank 1 on the device and hold FS1
  3. Observe that in the various steps 3 and 4, various message stacks are triggered in Bank 0 even though the footswitch was pressed down in Bank 1. Also when the Go To Bank message is in a Press stack, the LED of the switch in the new bank is turned on.

Expected behavior When a footswitch with a Go To Bank message is pressed, the device should change to that bank and not do anything else. Any input from that footswitch should be ignored until after it is released (and then honoured for subsequent presses).

Screenshots In the screenshot (of the Protokol MIDI monitor), I added a marker in between a/b/c versions. You can see that the different message stacks are triggered depending on Bank Jump times relative to switch press/release/hold.

Additional context

frenno commented 1 year ago

Bridge6SwitchBug.txt

This is a Bridge6 config file with all steps to 3a (Github doesn't let me attach JSON so you'll have to rename the extension)

samspencer5991 commented 1 year ago

addressed with v1.1.3

frenno commented 1 year ago
Capture2

Unfortunately this doesn't seem to be fully addressed in 1.1.3, I tested using the same steps as above plus a couple of other variants.

As far as I can tell, the firmware upgrade was successful (no error messages and the System info shows 1.1.3). I tried doing a factory reset as well but that didn't change anything.

samspencer5991 commented 1 year ago

Hmm ok, so it seems that the issue is separate with Go To Bank messages. I had only tested bank up/down, so I'll take another swing at this tomorrow.

frenno commented 1 year ago

Hi @samspencer5991, currently using firmware 1.2.0-alpha.5 and still seeing all the same results as in my previous comment (which was using 1.1.3).