Pirate-MIDI / Pirate-MIDI-BridgeOS

Documenting Bugs & Issues - Public Collaboration
10 stars 2 forks source link

webinterface, linked scrolling, choosen linked switch value from webpage list incorrect after 'send to device' #108

Closed Funky6ft6 closed 1 year ago

Funky6ft6 commented 1 year ago

Device(please complete the following information):

Describe the bug using scrolling linked function for a footswitch, the value configured in the linked footswitch parameter (e.g. ' 5' ) ends up as another number when 'send to device'.

If you look at the selection list of the linked switch, it is kind of strange list order: 1,3,4,5,6.

To Reproduce

preperation: configure switch number 5 for 'scrolling', set direction to forward, min/max to 0-127, steps 3, leave color, start edit.piratemidi.com, leave the rest of the prarmeters: enter menu, choose select, choose switch 5, choose select, select config, scroll to scrolling for primary function, go to right, and configure direction to forward, min/max to 0-127, steps 3, leave color, start edit.piratemidi.com, leave the rest of the prarmeters, choose save, scroll upo to switch ' messages', choose select, select scrolling, choose a function, in my caser I scroll Control Change, configure channel and CC#, choose 0 for value, exit, exit,exit, exit, exit. you're now back out of the menu.


Now, configure ' linked scrolling' via webinterface:

login with user account, choose " import from device", choose 'device', choose fs2, given that switch 2 is configured for ' scrolling', direction ' forward', choose ' scrolling linked'. in the box Switch Mode , choose direction Reverse in box " direction ', choose linked Footswitch number 5, choose save & close, choose 'send to device' .

on the unit itself, open menu by pressing sw 1 & 4, choose select, sscroll tot fs2, choose select, choose ' set'. from the already available config menu, press three times fs6, scrolling to the 3th column and confirm the number is 6, which is incorrect and should be 5.

Expected behavior The number on the hardware device should be 5 not 6.

Screenshots image

Additional context Tip for bug repair: As you can see in the image the list is incorrect, number 2 is missing and could cause the wrong numbering transmitted tot the device. So completing the list from the webpage probably solves this issue

Funky6ft6 commented 1 year ago

off course, the number 2 switch is left out because its the switch itself. You can't select the switch itself. I. So forget what I mentioned about the wrong list. I leave it, though for logging reasons, or @samspencer5991: should I remove it from the reported issue?

Funky6ft6 commented 1 year ago

I did some testing: When I was testing with switch number 1 and 4 for configuring delay mix up and down levels, the same error occured. The number saved for the linked switch seems 1 higher than the actual pointed switch, when using the webinterface and sending it to the hardware device. So 5 becomes 6 and 4 becomes 5.

samspencer5991 commented 1 year ago

Can you confirm if this is fixed in the latest beta version @Funky6ft6 ?