search

Pirate-MIDI / Pirate-MIDI-BridgeOS

Documenting Bugs & Issues - Public Collaboration
10 stars 2 forks source link

Sequential step labels - Descender being cut off #119

Closed grwxyz closed 1 year ago

grwxyz commented 1 year ago

Describe the bug When using characters with a descender (eg gpqy), the descender is being cut off (ie it doesn't display)

To Reproduce Steps to reproduce the behavior:

  1. Go to 'edit.piratemidi.com', sign in and connect to device.
  2. Create a 'Sequential' mode switch.
  3. Add a 'New Step'
  4. Add a label 'gipqy'
  5. Save and send to device
  6. Check the device display and notice that the bottom of the characters will appear cut off.

Expected behavior The characters are displayed correctly.

Screenshots If applicable, add screenshots to help explain your problem. gipqy

Additional context Add any other context about the problem here.

simonaglover95 commented 1 year ago

It's normal for the descender not to show on Extended UI, but in Simple UI we should be able to get this fixed in the next firmware update :)

grwxyz commented 1 year ago

The only time the “descender” doesn’t show is when using a sequential switch on the bottom row (ie FS1/2/3). You can see the sequential label drops down a few pixels, therefore cutting off the “descender”.

image

Note that it works (ie "descender” shows) on bottom row (ie FS1/2/3) for normal toggle buttons. Also works on top row for all buttons types.

simonaglover95 commented 1 year ago

Yes, as I said it's only unintentional in Simple UI, which we shall get fixed very soon :)