search

Pirate-MIDI / Pirate-MIDI-BridgeOS

Documenting Bugs & Issues - Public Collaboration
10 stars 2 forks source link

LFOs are not turned off with smart messages/switch groups #139

Open frenno opened 1 year ago

frenno commented 1 year ago

Device

Describe the bug LFOs with Trigger set to Toggle start and stop when the switch they are assigned to is pressed. However the do not start or stop when that switch is toggled on or off either with a smart message or by being part of a Switch Group.

To Reproduce

  1. Use a new blank template, add different CC messages to the Toggle On and Toggle Off messages of FS1 (eg CC-1-1-1 and CC-2-2-2)
  2. Add FS1 Primary and FS2 Primary to Switch group 1 of that bank (all other options can be defaults)
  3. Enable the LFO on FS1 (obviously Trigger > Hold is not affected by this but none of the other settings seem to make a difference). For the purposes of this bug report, set Messages to Toggle On (but choosing another stack doesn't make a difference in general)
  4. Press FS1, then FS2
  5. Using a MIDI monitor, observe that the Toggle Off message for FS1 has been sent but FS1's LFO is also still sending
  6. Turn off LFO by pressing FS1 again (turns off LFO even though it has already toggled off?)
  7. Add a smart message to FS3: Switch Off > FS1 > Primary
  8. Press FS1, then FS3
  9. Using a MIDI monitor, observe that the Toggle Off message for FS1 has been sent but FS1's LFO is also still sending (actually I think the switch sometimes gets confused about which state it is in so it might not send the Toggle Off message - it definitely will if you power off then on again before pressing FS1 then FS3, assuming you don't have remember switch states enabled)

Expected behavior LFO should turn on oroff whenever the switch is turned on or off (whether by pressing it, Switch Group or Smart Message)

Additional context A "Switch On" smart message will not start the LFO either. Didn't test Switch groups set to turn on the switch with the LFO.