search

Pirate-MIDI / Pirate-MIDI-BridgeOS

Documenting Bugs & Issues - Public Collaboration
10 stars 2 forks source link

Switch "Copy From" on device misses LFO "MESSAGES" field #155

Closed frenno closed 1 year ago

frenno commented 1 year ago

Device

Describe the bug When copying a switch using the on-device menu, the MESSAGES field of the LFO settings is not copied (other fields seem to all be copied correctly).

To Reproduce

  1. Go to Menu > Switches > Switch 1 > LFO
  2. Messages field is blank, set to Toggle On (or anything other than blank)
  3. Menu > Switches > Switch 2 > Copy From and select switch 1
  4. After device restart, go to Menu > Switches > Switch 2 > LFO and the MESSAGES field is blank

Expected behavior MESSAGES field should be copied

samspencer5991 commented 1 year ago

@frenno This is not so much a bug, but a limitation of the way that banks are stored and dynamically updated. Whilst it is technically possible to ensure that the target message stack is copied, it will require a non-trivial amount of development and testing and will also be very difficult to maintain in firmware revisions.

This copy function is also available in the editor and handled fully there so we will be adding a note to the user manual pointing out that if you're copying a switch including LFO assignment using the onboard navigation, the LFO message stack target must be manually set.