search

Pirate-MIDI / Pirate-MIDI-BridgeOS

Documenting Bugs & Issues - Public Collaboration
10 stars 2 forks source link

Sequential Note date does not save correctly #172

Closed MIDISYNTHNOTE closed 1 year ago

MIDISYNTHNOTE commented 1 year ago

NOTE: All of my editing is done in the web editor

Describe the bug All my editing is done in the web editor.

When you program Midi note data into one footswitch that is set to sequential the last note does not turn off even though I program it to turn off that specific note, it does not turn off the last note in the sequence. My Device would not save the info I programed in until I deleted the first step no matter how many times I tried to save it. It's strange because it works great with 4 steps but will not work with 7 or 8 steps.

To Reproduce Steps to reproduce the behavior:

  1. Go to... Switch messages
  2. Click on... Sequential
  3. Program 7 to 8 steps with 2 MIDI notes for each step so the last note turns off when you press the footswitch (it would also be nice if switch groups worked with sequential steps, but they do not work when sequential is selected.

Expected behavior It should save the data correctly

MIDISYNTHNOTE commented 1 year ago

hello this is the same person that made the report for the bug.... I noticed that my bridge will not save anything now. I wonder if it has something to do with my device. everything saved and worked perfectly until today. The only thing I changed were the colors of the foot switches.

samspencer5991 commented 1 year ago

Hey mate,

I highly doubt it’s something to do with your device specifically. You didn’t mention in your issue whether the config was being done onboard your device or in the editor. Can you please update it with that info?

On Tue, 21 Mar 2023 at 11:12 am, MIDISYNTHNOTE @.***> wrote:

hello this is the same person that made the report for the bug.... I noticed that my bridge will not save anything now. I wonder if it has something to do with my device. everything saved and worked perfectly until today. The only thing I changed were the colors of the foot switches.

— Reply to this email directly, view it on GitHub https://github.com/Pirate-MIDI/Pirate-MIDI-BridgeOS/issues/172#issuecomment-1477115178, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFHZWVDXEFUZE32WJQULAS3W5DW73ANCNFSM6AAAAAAWBX23BM . You are receiving this because you were assigned.Message ID: @.***>

MIDISYNTHNOTE commented 1 year ago

Okay After shutting down the unit for a while and coming back now it is saving most things correctly... except for the sequential midi note data. If I try to change or edit the 1st step on sequential MIDI note data it does not work even if the editor says that it's saved.

for the record.... I tried to save note data that I edited and the application says that it's saved and I unplug my machine and replug it back into a synthesizer and it reverts back and the data does not get saved.

MIDISYNTHNOTE commented 1 year ago

Yes I'm doing all the programming in the editor.

I will update GitHub right now

On Mon, Mar 20, 2023, 7:15 PM Sam Spencer @.***> wrote:

Hey mate,

I highly doubt it’s something to do with your device specifically. You didn’t mention in your issue whether the config was being done onboard your device or in the editor. Can you please update it with that info?

On Tue, 21 Mar 2023 at 11:12 am, MIDISYNTHNOTE @.***> wrote:

hello this is the same person that made the report for the bug.... I noticed that my bridge will not save anything now. I wonder if it has something to do with my device. everything saved and worked perfectly until today. The only thing I changed were the colors of the foot switches.

— Reply to this email directly, view it on GitHub < https://github.com/Pirate-MIDI/Pirate-MIDI-BridgeOS/issues/172#issuecomment-1477115178 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AFHZWVDXEFUZE32WJQULAS3W5DW73ANCNFSM6AAAAAAWBX23BM

. You are receiving this because you were assigned.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/Pirate-MIDI/Pirate-MIDI-BridgeOS/issues/172#issuecomment-1477117438, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6T36YI2VT7OJQ74WUAPGFTW5DXITANCNFSM6AAAAAAWBX23BM . You are receiving this because you authored the thread.Message ID: @.***>

MIDISYNTHNOTE commented 1 year ago

I didn't think of it until you asked but I tried to program sequential notes into the actual unit and not use the web editor. and it worked! It would be nice if the web editor worked though. because I'm programming in noye data it takes an immense amount of time.

side note: There's a few things I've noticed You can program directly into the machine but they are not on the web editor. for example TRS auxiliary foot switch bank change cannot be programmed in the web editor without changing settings in the machine itself.

There's a lot of back and forth not knowing If I should be programming it into the unit itself or if it can be done on the web editor. It would be great if the web editor and the unit itself had the exact same options.

Thanks again for your time.

samspencer5991 commented 1 year ago

That’s good to know as it helps dial in exactly where the error is occurring.

The editor and onboard settings are both identical, and if something is missing, it’s a bug, not by intention.

The reason I asked isn’t because they should behave differently, but to get as much information on the issue as possible.

On Wed, 22 Mar 2023 at 11:00 am, MIDISYNTHNOTE @.***> wrote:

I didn't think of it until you asked but I tried to program sequential notes into the actual unit and not use the web editor. and it worked! It would be nice if the web editor worked though. because I'm programming in noye data it takes an immense amount of time.

side note: There's a few things I've noticed You can program directly into the machine but they are not on the web editor. for example TRS auxiliary foot switch bank change cannot be programmed in the web editor without changing settings in the machine itself.

There's a lot of back and forth not knowing If I should be programming it into the unit itself or if it can be done on the web editor. It would be great if the web editor and the unit itself had the exact same options.

Thanks again for your time.

— Reply to this email directly, view it on GitHub https://github.com/Pirate-MIDI/Pirate-MIDI-BridgeOS/issues/172#issuecomment-1478742091, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFHZWVAGL74QDLPOPSVQNQDW5I6IHANCNFSM6AAAAAAWBX23BM . You are receiving this because you were assigned.Message ID: @.***>

MIDISYNTHNOTE commented 1 year ago

I didn't think of it until you asked but I tried to program sequential notes into the actual unit and not use the web editor. and it worked! It would be nice if the web editor worked though. because I'm programming in noye data it takes an immense amount of time.

side note: There's a few things I've noticed You can program directly into the machine but they are not on the web editor. for example TRS auxiliary foot switch bank change cannot be programmed in the web editor without changing settings in the machine itself.

There's a lot of back and forth not knowing If I should be programming it into the unit itself or if it can be done on the web editor. It would be great if the web editor and the unit itself had the exact same options.

Thanks again for your time...

samspencer5991 commented 1 year ago

I've tracked down the cause of this bug and will have a fix out for it next week.