search

Pirate-MIDI / Pirate-MIDI-BridgeOS

Documenting Bugs & Issues - Public Collaboration
10 stars 2 forks source link

Can't disable both bank triggers #176

Closed GriffinSauce closed 1 year ago

GriffinSauce commented 1 year ago

Device(please complete the following information):

Describe the bug It's not possible to disable both bank triggers:

To Reproduce Steps to reproduce the behavior:

Expected behavior It disables both triggers.

Screenshots

CleanShot 2023-03-26 at 21 55 23@2x

Additional context I have a dual aux switch to do bank switches, it should be possible to disable the triggers on the device completely. This might just be an editor input-validation bug.

samspencer5991 commented 1 year ago

Absolutely just an input validation error. As you would expect, it won't let you make both triggers the same thing, but there obviously needs to be an exception for the none option. @konnsim

konnsim commented 1 year ago

@GriffinSauce thanks for picking that up, just pushed a hotfix.

GriffinSauce commented 1 year ago

Thanks @konnsim, works now!