search

Pirate-MIDI / Pirate-MIDI-BridgeOS

Documenting Bugs & Issues - Public Collaboration
10 stars 2 forks source link

Malformed data from bankSettings request #23

Closed GriffinSauce closed 2 years ago

GriffinSauce commented 2 years ago

Device(please complete the following information):

Describe the bug

The data returned by a bankSettings request is not valid JSON. The sequentialLabels data for each footswitch is malformed: "sequentialLabels": [f08080"], (notice the missing opening quote)

To Reproduce Steps to reproduce the behavior:

  1. Send 0,DREQ
  2. Send 1,bankSettings,0
  3. Response is kaput

Expected behavior Valid JSON :D

Additional context

Here is the complete output: bankSettings.txt - search for "malformed" to find the issues.

Edit: I put DTXR but this is about DREQ, fixed above 🙏

GriffinSauce commented 2 years ago

Thanks for the fix @samspencer5991 ! 🙌