Pirate-Weather / pirateweather

Code and documentation for the Pirate Weather API
Apache License 2.0
636 stars 29 forks source link

`pressure` is surface-level pressure not sea-level pressure #265

Closed cloneofghosts closed 3 weeks ago

cloneofghosts commented 1 month ago

Describe the bug

I noticed the other day that the pressure values shown by Pirate Weather are much lower compared to other sites. It then dawned on me that Pirate Weather is using surface-level pressure instead of sea-level pressure which most other sites used.

I checked the Dark Sky documentation and it defines pressure as:

pressure The sea-level air pressure in millibars.

You've mentioned in the past that you want to try and keep things the same way that Dark Sky did things so this is definitely a bug.

Expected behavior

Pressure should be sea-level pressure

Actual behavior

Pressure is surface-level pressure

API Endpoint

Production

Location

A good location for comparisons is Calgary, AB

Other details

No response

Troubleshooting steps

alexander0042 commented 1 month ago

Can't believe I've never noticed this before! This is the next priority to get fixed. It's an easy enough changeover, so should happen this week

cloneofghosts commented 1 month ago

Maybe surface level pressure could be an additional variable which could be shown using the version=2 query string?

cloneofghosts commented 3 weeks ago

Noticed this has been fully fixed in V2.1.2