search

Pirate-Weather / pirateweather

Code and documentation for the Pirate Weather API
Apache License 2.0
671 stars 29 forks source link

Day/Night Forecast #49

Open cloneofghosts opened 1 year ago

cloneofghosts commented 1 year ago

It would be nice if the summary field could be split into two summary fields with one being for daytime conditions and the other one for nighttime conditions. One of my main complaints about the summaries from DarkSky is that since they kept the summaries breif it would often miss out on large portions of the day depending on the forecast. Some examples

Foggy in the morning. Possible light rain in the morning. Rain and windy overnight.

Those summaries don't provide much information outside of those timeframes so you'd have to look at the hourly forecast anyway to get more information and having it split into day and night helps to solve that problem.

As for the existing summary/icon fields they could either be used to show a summary of the day like they are now or it could show the day information during the day and then swap to the night information at night. The first option is something weather.com does with their API so maybe that would be better?

github-actions[bot] commented 1 year ago

There has been no activity on this issue for ninety days and unless you comment on the issue it will automatically close in seven days.

cloneofghosts commented 1 year ago

Looks like this one was passed over. Thoughts about adding something like this when text summaries are implemented?

If the text summaries are going to take a while can you add the no-autoclose label to this issue so it doesn't attempt to auto-close this issue every 90 days.

alexander0042 commented 1 year ago

Yup, let's keep this one open! Once I get the daily max stuff sorted out, complete text summaries in the Dark Sky style are next

cloneofghosts commented 1 year ago

@alexander0042 A way to keep this open without it automatically adding the stale label would be to either assign this issue to yourself or add the keep label to this issue. Either of those will prevent the bot from marking this as stale in the future.

alexander0042 commented 1 year ago

Perfect! Label is added

cloneofghosts commented 1 year ago

@alexander0042 I see it has the enhancement label. The only ignored label is called keep though if you want it to ignore items tagged as enhancement and bug you can easily add it by modifying lines 16 and 17 https://github.com/alexander0042/pirateweather/blob/main/.github/workflows/stale.yml to be

exempt-issue-labels: 'keep, enhancement, bug' exempt-pr-labels: 'keep, enhancement, bug'

alexander0042 commented 1 year ago

Eventually I figure things out, keep label makes a lot of sense

cloneofghosts commented 1 year ago

Was thinking about this and maybe instead of having a day/night summary/icon fields it might be better to have a section to display a forecast in day/night chunks.

So it would have a day block which displays the forecast from 6am to 6pm for the day and the night block would be from 6pm to 6am. Maybe once there are fewer than x number of hours left the block no longer shows since it doesn't make sense to show a forecast for only a few hours. It could maybe have the same fields as the hourly section does currently.

To me it would make more sense then having a day & night summary field and I know that most other APIs do offer the ability to have a day & night forecast and would be useful for apps which would like to show this information.

This idea came about since I noticed that Breezy Weather has PW as a weather provider but the daily information becomes limited after 48h since they do not use the extended hourly forecasts.