search

PirateBox-Dev / PirateBoxScripts_Webserver

PirateBox Scriptcollection for running in Webserver
GNU General Public License v3.0
206 stars 102 forks source link

Lock Shoutbox #125

Closed miketweaver closed 8 years ago

miketweaver commented 9 years ago

This should 'lock' the sending button until the post is finished.

Should solve #67 .

MaStr commented 9 years ago

The button seems not to be disabled, it seems not to work.

In addition, I have to admit, that you have fixed the problem of the slow loading shoutbox when posting :+1:

I think it is now possible to even send empty lines.. (maybe it was possible before, too wondering )

miketweaver commented 9 years ago

I'm not sure I understand what you're saying. Are you saying that the button does not disable? Or that I fixed the problem?

In most cases, the button should only be disabled for milliseconds. If the system is preforming fast, you shouldn't even see it at all.

Yes, you can send empty lines. This is the way it's always functioned. I only added an event before and after the POST to "/cgi-bin/psowrte.py". I didn't change the POST itself.

miketweaver commented 9 years ago

I noticed that the button text didn't switch at the right time. That should be fixed now.

MaStr commented 9 years ago

that looks very good. I'm testing it on my mobile devices, but I guess that should work out as well.

edit: on iOS-iPhone the non disappearing box covers the percentage. And as you can't "hover out", it does not vanish anymore. On my old Android phone no problem (there the shoutbox doesn't refresh in general- but that isn't your fault)

MaStr commented 8 years ago

merged to feature branch 1.1.0