Open ucarion opened 7 years ago
The C-GOOD-ERR) API guideline from the Rust API guidelines states that "Error types should be meaningful and well-behaved". If an error type does not implement std::error::Error
, it will not be usable in other error handling mechanisms and libraries. Also problematic, as a consequence to this, is the fact that it does not implement Debug
, thus disabling trivial methods such as unwrap()
.
Notice that this code has moved here https://github.com/PistonDevelopers/graphics/blob/master/src/glyph_cache/rusttype.rs
According to https://github.com/PistonDevelopers/gfx_texture/blob/master/src/lib.rs, it seems error types are reexported from Gfx.
@bvssvni I was looking for the concrete GlyphCache
implementation, but the documentation would direct me to a broken link. Thanks! I also found a related issue: gfx-rs/gfx#506
Head's up! The issue was created before LL transition. If you are to submit a PR (that would be great!), it needs to go towards pre-ll
branch (assuming you need it for gfx-0.16 and up). If it's going to be non-breaking, we can port the PR to v0.16
branch and release an update.
I noticed this when trying to add
error_chain
to my project, because the following doesn't compile: (piston_window::Glyphs
isgfx_graphics::GlyphCache
)The error notes:
I think this would be fixed if
glyph::Error
implementedstd::error::Error
. However, I don't claim to fully understand the situation. Could this implementation be added?