Closed Kagami closed 9 years ago
I think the stream
version should be the default, and s
prefix is not too sound. Canvas
API can follow gfx-debug-draw
case (draw_end_canvas
). @stjahns would you see it fit?
I think the stream version should be the default
That would be a breaking change. Not a big deal at this level of development though, so it's ok.
Canvas API can follow gfx-debug-draw case (draw_end_canvas)
Ok, we may be consistent with gfx-debug-draw
here.
Would like to hear @stjahns opinion too.
Seems like @stjahns is quite inactive last time and one of the library users waiting for this.
I've rebased over master, made draw_end[at] accept the stream by default and also add `canvas` aliases instead because it's more logical IMO.
@kvark what do you think?
@Kagami It's a bit unfortunate to see this much boilerplate just to support Canvas
. I believe the user would need to change less/nothing in case they need it:
let mut stream = (&mut canvas.renderer, &convas.output);
)Hence, I'm leaning towards gfx_text
providing only Stream
API. The burden of extracting the stream will be removed with https://github.com/gfx-rs/gfx-rs/issues/690, which would allow gfx_text
to have its own factory.
@LaylConway - would it hurt your use case?
Ok, fixed. Does it look good to you now?
@LaylConway actually wanted stream API, so it should be ok.
I'm personally of the opinion that Canvas is an unneeded abstraction now that Stream is provided. I've been using this fork so far in Phosphorus and it seems to work great for my needs.
@LaylConway thanks for the feedback!
sdraw_end
,sdraw_end_at
get_batch
,get_batch_at
Fixes #4 cc @kvark