search

PistonDevelopers / gfx_text

Draw text for gfx using freetype
http://docs.piston.rs/gfx_text/gfx_text/
MIT License
22 stars 12 forks source link

BREAKING CHANGES: rename draw methods #24

Closed Kagami closed 9 years ago

Kagami commented 9 years ago

I just realized the current Renderer's method names are kinda stupid: actually we don't draw anything on .draw call, but add several vertexes instead. So this changes should make things more logical in my opinion:

draw -> add
draw_at -> add_at
draw_end -> draw
draw_end_at -> draw_at

This is breaking change and planned for gfx_text 0.4.0. I hate breaking APIs but better to do that early.

cc @kvark @stjahns @LaylConway

kvark commented 9 years ago

Excellent!

Regards, Dzmitry

On May 31, 2015, at 16:02, Kagami Hiiragi notifications@github.com wrote:

I just realized the current Renderer's method names are kinda stupid: actually we don't draw anything on .draw call, but add several vertexes instead. So this changes should make things more logical in my opinion:

draw -> add draw_at -> add_at draw_end -> draw draw_end_at -> draw_at This is breaking change and planned for gfx_text 0.4.0. I hate breaking APIs but better to do that early.

cc @kvark @stjahns @LaylConway

You can view, comment on, or merge this pull request online at:

https://github.com/PistonDevelopers/gfx_text/pull/24

Commit Summary

BREAKING CHANGES: rename draw methods File Changes

M README.md (10) M examples/styles.rs (14) M src/lib.rs (52) Patch Links:

https://github.com/PistonDevelopers/gfx_text/pull/24.patch https://github.com/PistonDevelopers/gfx_text/pull/24.diff — Reply to this email directly or view it on GitHub.

LaylBongers commented 9 years ago

Sounds like a good change, thanks for the heads up on it being breaking

Kagami commented 9 years ago

Thanks for the responses. Merging.