search

PistonDevelopers / glutin_window

A Piston window back-end using the Glutin library
MIT License
25 stars 40 forks source link

Automatic context resize in MacOS platform #192

Closed AleCamara closed 3 years ago

AleCamara commented 3 years ago

Hey! First PR to any Piston-related repo. I found this issue: https://github.com/PistonDevelopers/graphics/issues/1129 As the other issue mentions, the problem is that in some platforms (MacOS and Wayland) the glutin context needs to be resized when the window resizes. Check the docs: https://docs.rs/glutin/0.20.1/glutin/struct.WindowedContext.html#method.resize I've fixed this problem on MacOS, where I can test the fix. I presume the problem still persists in Wayland. I'm also pretty new to rust, so happy to change anything to make it idiomatic!

AleCamara commented 3 years ago

I kept using Rust and found this simpler way to achieve the conditional execution of the resize code.

bvssvni commented 3 years ago

Merging

bvssvni commented 3 years ago

Thanks!