Discussion about design so far

PistonDevelopers / graphics_tree

A 2D graphics backend for Piston-Graphics that stores and optimizes commands

Apache License 2.0

2 stars 1 forks source link

Discussion about design so far #6

Open bvssvni opened 8 years ago

bvssvni commented 8 years ago

I made GraphicsTree implement Graphics, because:

It can override the default trait methods to store primitives
Makes it possible to use GraphicsTree in existing code
If we experiment with new things on top of piston-graphics, it will automatically be supported by code using GraphicsTree
To get full support initially, we only need the required methods on Graphics
The backend it renders to can choose whether to handle primitives or just triangle lists
Seems easy to use it with a TextureBuffer object that maps textures

cc @mitchmindtree

aochagavia commented 8 years ago

I just heard of this library today on IRC because I was experiencing performance issues with the opengl backend (I was drawing about 5000 ellipses). As a current workaround, I am using this function: https://github.com/aochagavia/rocket/blob/3632d4d80c859ac5345822be10e075cc73b17236/src/models/world.rs#L49

I have not looked into this library yet, but from the description it seems that I wouldn't need to have this workaround anymore. Is that true? What needs to be implemented before it is published?

bvssvni commented 8 years ago

Publised as 0.1.0 https://github.com/PistonDevelopers/graphics_tree

Btw, the opengl backend is currently the slowest among OpenGL/Gfx/Glium.

Notice that graphics_tree has a memory leak when updating an image: https://github.com/PistonDevelopers/graphics_tree/issues/5.

aochagavia commented 8 years ago

Awesome!