Fixed all of the array patterns and gfx macros

PistonDevelopers / hematite

A simple Minecraft written in Rust with the Piston game engine

http://hematite.piston.rs/

MIT License

1.86k stars 105 forks source link

Fixed all of the array patterns and gfx macros #218

Closed kvark closed 9 years ago

kvark commented 9 years ago

An attempt to make it run on rust-beta. Please take it from here, if you can.

cc @mattico @eddyb

eddyb commented 9 years ago

Removing array patterns makes me sad :(. I believe there are methods like array.x() for components, maybe you could use those instead of raw indexes?

kvark commented 9 years ago

@eddyb you think I'm happy? Going through all of those wasn't the most pleasuring evening for me. Really though, I think this code just needs to use a math library (vecmath?). Also, I didn't know about array.x() syntax, and I don't think it makes much sense, considering that element semantics might be anything (not just the coordinates).

kvark commented 9 years ago

This should be ready now. I was able to actually run it.

kvark commented 9 years ago

@mattico thanks for the review! windows build should be good now.