Provide proper tests for server.properties

PistonDevelopers / hematite_server

A Minecraft server clone

http://hematite.piston.rs/

MIT License

140 stars 16 forks source link

Provide proper tests for server.properties #103

Closed toqueteos closed 8 years ago

toqueteos commented 8 years ago

This is a follow-up PR of https://github.com/PistonDevelopers/hematite_server/pull/102

Changes:

Properties struct now derives PartialEq deriving so we can use the assert_eq! macro in the tests.
Properties::load now returns an io::Error if it finds an unknown property.

/cc @fenhl

toqueteos commented 8 years ago

Woops, needs a rebase because we just merged #102 D'oh!

EDIT: Done!

fenhl commented 8 years ago

It's funny how this test passes even though the parsing is completely broken (#104). Maybe add another equivalent test for a custom server.properties file?

toqueteos commented 8 years ago

Rebased with latest master (contains #104).

toqueteos commented 8 years ago

Force pushed with three tests and a new commit message:

[x] Properties::load/save using Properties::default.
[x] Properties::load/save using Properties::default + Properties.server_port=25570 (not default value).
[x] Properties::load with unknown properties failing as expected.

toqueteos commented 8 years ago

Ping @fenhl