Remove PhysFSContext as it gives the false illusion of being able to have multiple independent contexts. - Githubissues

PistonDevelopers / physfs-rs

Rust bindings for PhysFS

zlib License

8 stars 3 forks source link

Remove PhysFSContext as it gives the false illusion of being able to have multiple independent contexts. #35

Closed cirla closed 9 years ago

cirla commented 9 years ago

NOTE: Not ready to be merged. Submitting PR for purposes of discussion.

As per discussion in #2:

Remove PhysFSContext as it gives the false illusion of being able to have multiple independent contexts.
Remove static mutext as (non-File) PhysFS methods are thread-safe.
Add per-File mutex for thread safety.

Also

Update ffi calls to latest rust
- CString::from_slice -> CString::new
- c_str_to_bytes -> CStr::from_ptr

TODO

Investigate which tests can and can't be run in parallel.
- Probably implement a setup/teardown so that all tests can be run in parallel.

bvssvni commented 9 years ago

Close because of outdated.