search

PistonDevelopers / wavefront_obj

A parser written in rust for the wavefront .obj file format.
MIT License
27 stars 18 forks source link

Added support for groups. #48

Closed hadronized closed 8 years ago

hadronized commented 8 years ago

A lot of code has been modified to take groups into account, because those are element-based and stateful. Shape is now called Primitive and the ne Shape type gathers a Primitive along with the associated groups. That breaks retrocompatiblity, so I’ll let you chose what to do about that. Alternative solution is to modify the Shape type by prepending a Vec for each variant, but that’s boiler plate and a bit overkill (more code would be impacted though).

hadronized commented 8 years ago

Hm maybe the tests are broken now, I’ll fix that.

cgaebel commented 8 years ago

Can you add a test for the new functionality?

cgaebel commented 8 years ago

Thanks for the patch! Merged as wavefront_obj v4.0.0.