Publish 7.0.0 - Githubissues

PistonDevelopers / wavefront_obj

A parser written in rust for the wavefront .obj file format.

MIT License

27 stars 18 forks source link

Publish 7.0.0 #64

Closed bvssvni closed 5 years ago

bvssvni commented 5 years ago

Merging.

hadronized commented 5 years ago

I don’t really get why 7.0.0. It could have been 6.0.1 as I just patched a bug, right?

bvssvni commented 5 years ago

@phaazon I think you are right. I saw this https://github.com/PistonDevelopers/wavefront_obj/commit/1c069d4665f8b642c194409cdf305911b430a620#diff-72dac0bc15578b7a7f1e37d8d65305dbR55 and bumped it to 7.0.0 to be safe.

hadronized commented 5 years ago

Hm, yeah, it’s public. I guess it should have been minor then. I think it’s okay, it’s better to have a breaking change that doesn’t break anything than the other way around. :yum:

bvssvni commented 5 years ago

The rule is that the first non-zero number must be bumped when:

there is a breaking change
there is a bump in the first non-zero number of any dependencies

I am investigating whether we can add some attribute to deny pub when pub(crate) would suffice.

bvssvni commented 5 years ago

I found it: #![deny(unreachable_pub)].

hadronized commented 5 years ago

I didn’t even know it existed. Very nice!