Pistonite / botw-ist

NEW IST Simulator
https://ist.itntpiston.app/
MIT License
6 stars 2 forks source link

Mcount <= 1 inconsistency? #22

Closed sobolews closed 12 months ago

sobolews commented 12 months ago

I don't fully understand this stuff myself so just passing the info along :)

sim script: https://ist.itntpiston.app/?c=H4sIAAAAAAACA5VTTU%2FjMBC951eMtBKnPSSFPfbQLC3srSLsCe1hkkwbq67Ha7ug8uvxV0oqpAKnjif2e2%2Fem%2F5RwgmU4pWggkc23eB%2FH%2FiI8rfE455N6N8ZQrfEraSaX%2Fx55dvW3b6QlGRs7qHsWIX6pixLWBgzlithaHKsed9OjgvVCVIudSq4P0qBqhkEyd4f1%2Byk6J%2Bk2ND8uiz%2FhRuExh1rtDayGrZD06EMOmvcUb%2FQWtKTNqKjeXXz6ycMel7N4tNGE%2FUb5oDcSHThzRqNH0z0ZMKgAaew%2BEyAFrbU4sFxcWtYgwvepPITA4rl%2F4PQ56blXpwy12cm5950%2BqL2ADuorsFKdrZYovMsNsgeZUwiuuBK8rBYi253%2BParxnvx%2FvRy8FniBdBpADEsiGkVDyQZPdnAHBCSTZH6r6KPboJQ0RSYwWjsZItyS8cB3q%2BOpn1J3gVFfYDJ4BvD%2BzP4FCDYtL%2FTzxS9GSI5tJ49U8BpxNMu%2FFBs9iiBFdmiv9KwDcMDhemh9Tr0mMf5jh0ykL9ik0xPGAVlPbOs%2B3Qz9RPJJlphgxVZbBsTwpBQ2LzRnFH4%2BPd4A8Jr8qJDBAAA

actual in game result: https://cdn.discordapp.com/attachments/995178098477760663/1167139544026595358/2023-10-26_18-18-29.mp4?ex=654d0a67&is=653a9567&hm=bc4a21d6c67e37e1ca3f8390fd9c7d2ed891a42923627c82148bc8b7fa54822c&

discussion: [10:39 AM]Tao: is line 16 where the sim goes wrong? [10:39 AM]PancakeTurtle: looks like it honestly [10:39 AM]PancakeTurtle: cause it has two stacks of arrow [10:39 AM]BingsF: is that mcount 0 shenanigans [10:39 AM]PancakeTurtle: -1 [10:40 AM]Tao: looks like sim assumes game won't check that you already have >999 arrows when mcount <= 1 [10:40 AM]PancakeTurtle: cause we transfer to claymore not fish that step i am pretty sure [10:40 AM]PancakeTurtle: since we can eat fish in the next steps

pearfalse commented 12 months ago

Looks like this was fixed with a recent sim update and deployment.

The sim previously thought the arrow stack should dupe due to mCount 0 shenanigans. It's actually not that at all (#20), and the sim behaves correctly now.

Pistonight commented 12 months ago

Sounds good, thanks for the fix