[Bug] Items like enchantments and potions shouldn't have EMC or should store nbt

[OffsetMonkey538]

When you put an enchantment book or potion into the Alchemy Table, they don't keep NBT so they turn into no-effect versions.

I'm not sure how ProjectE dealt with this, so we should probably check that, but here are the options:

• Set their EMC to 0 so they can't be put into the table.
• Store the NBT data of items put into the alchemy table. Again, depends on how ProjectE dealt with this

[mymai1208]

I think keeping NBT should be unregistrable because it would be unbalanced by replicating items in storage mods (sorry bad english)

[OffsetMonkey538]

Hmm yeah that makes sense, I'm gonna install ProjectE and see how it deals with this

[OffsetMonkey538]

Ok ProjectE seems to have the same bug with enchantments, but it does store potions separately and has different EMC values for different potions

[OffsetMonkey538]

Hmm what if we make an exception to potions and enchant books and store their nbt? Hmm what about items with enchantments? This would also probably need quite a few changes of how the mod works

[OffsetMonkey538]

Then we'd get to the question of how much EMC different potions and enchanta should have. What about modded potions and enchants? Would those just have a default value that maybe scales with the enchant level?

[mymai1208]

Hmmm, that would be difficult because it would be unbalanced depending on the effect of the enchantment.

[BananaPuppy]

@OffsetMonkey538 modded enchantments should just default to unobtainable through EMC unless specified through the api by the mod, as is the current behavior with vanilla enchantments ie: item with modded enchantment goes into Alchemy Table -> Alchemy Table stores non-enchanted item

[BananaPuppy]

although this would be quite a bit more complicated to implement, and slightly unrelated. the api could also allow for custom nbt behavior for the EMC value. edit: this would make it easier to implement custom behavior for other nbt based items such as tipped arrows, and any future nbt behavior implemented by mojang.

[OffsetMonkey538]

This makes most sense to me: Instead of just storimg the item ID, we store an item stack as NBT instead. We could default to stripping the stack of everything other than the id and make exceptions for enchantment books, potions, tipped arrows, etc and also allow that to be done by other mods via the api.

I might slowly start working on this at some point so I guess I'll assign this to myself. If you have any more suggestions or objections, feel free to put them here.