search

Pitayan / gatsby-theme-pitayan

A minimal blog theme plugin for Gatsby
https://pitayan.github.io/gatsby-theme-pitayan/
MIT License
30 stars 11 forks source link

Fix eslint #21

Closed daiyanze closed 1 year ago

panzerstadt commented 1 year ago
daiyanze commented 1 year ago

@panzerstadt Maybe this issue too boring XD? There's another one of implementing commenting function.

panzerstadt commented 1 year ago

Nono that gif is meant to say I’m excited to start contributing! XD

On Sun, Feb 12, 2023 at 22:20 Yanze Dai @.***> wrote:

@panzerstadt https://github.com/panzerstadt Maybe this issue too boring XD? There's another one of implementing commenting function.

— Reply to this email directly, view it on GitHub https://github.com/Pitayan/gatsby-theme-pitayan/issues/21#issuecomment-1427031841, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEN5KIHEF2UVJK4D7RH3XADWXDPSLANCNFSM5VKCXA4Q . You are receiving this because you were mentioned.Message ID: @.***>

panzerstadt commented 1 year ago

hmm can you give me more context? i tried running:

npm -w packages/www run develop

the www package doesn't seem to have any issues, or rather it doesn't have any code that needs linting.

the gateby-theme-pitayan refuses to build due to gatsby-config not being able to be exported as a function.

image

would appreciate some pointers on where to look! (as well as how to setup)

daiyanze commented 1 year ago

How was the npm i? Hope it was a clean installation with no errors. (Btw, need to use Node 18+)

And which directory were you at while executing the command of npm -w packages/www run develop?

panzerstadt commented 1 year ago

ok played around with it more and realised i'm not supposed to run develop on the plugin itself (sidenote: if the scripts on packages/gatsby-theme-pitayan are not supposed to be run, perhaps we should remove them)

panzerstadt commented 1 year ago 
warn gatsby-plugin-react-helmet: Gatsby now has built-in support for modifying the document head. Learn more at https://gatsby.dev/gatsby-head
warn Plugin `@pitayan/gatsby-theme-pitayan` has customized the GraphQL type `Mdx`, which has already been defined by the plugin
`gatsby-plugin-mdx`. This could potentially cause conflicts.
warn There are conflicting field types in your data.
warn You can't use childImageSharp together with SiteLogo.svg — use publicURL instead. The childImageSharp portion of the query in this file
will return null: undefined

are these the eslint warnings that you're looking to fix?

daiyanze commented 1 year ago

Em... That means eslint is still working on your side? If so, I think we could close this ticket asap

panzerstadt commented 1 year ago

i guess eslint is still working as expected.