search

Pitayan / gatsby-theme-pitayan

A minimal blog theme plugin for Gatsby
https://pitayan.github.io/gatsby-theme-pitayan/
MIT License
30 stars 11 forks source link

Update BottomFooter to use siteMetadata #24

Closed murtuzasyed closed 2 years ago

murtuzasyed commented 2 years ago

Hi, Thanks for the great work in creating this theme. Trying to use it for a pet project and was looking to know if we can update the BottomFooter component to use siteMetadata https://github.com/Pitayan/gatsby-theme-pitayan/blob/master/packages/gatsby-theme-pitayan/src/components/BottomFooter/index.tsx#L21

daiyanze commented 2 years ago

Oops. That's a mistake. I can take care of this soon

murtuzasyed commented 2 years ago

Awesome, Thanks @daiyanze

daiyanze commented 2 years ago

Hi @murtuzasyed! I think I've fixed the issue with this PR https://github.com/Pitayan/gatsby-theme-pitayan/pull/27.

A prerelease version has been published to NPM (0.4.3-next.0). Could you please try it out on your side?

murtuzasyed commented 2 years ago

@daiyanze , thanks for the update. It works now for the name but the site description is empty. Here;s how my configuration looks image image

daiyanze commented 2 years ago

@murtuzasyed Your configs look good to me (except the "description" under the plugin options. You don't need to put description there).

It worked for me just by changing the name and description of siteMetadata.

image

image image

Maybe you could try removing the Gatsby cache?

daiyanze commented 2 years ago

Hi @murtuzasyed! Let me merge this PR #27 to fix the issue. Please open up a new issue ticket if the above mentioning doesn't help out.