search

Pitayan / gatsby-theme-pitayan

A minimal blog theme plugin for Gatsby
https://pitayan.github.io/gatsby-theme-pitayan/
MIT License
30 stars 11 forks source link

Failing in ci build due to missing heading tag in post markdown file #43

Closed remiks closed 1 year ago

remiks commented 1 year ago

Hey @daiyanze ! We are experiencing some trouble in building v0.5.1 in CI. Was wondering if you could have a look? Our deploy file https://github.com/amestofortytwo/blog/blob/c4b9ba6e8840da07cbc1a331f6b090a245db84af/.github/workflows/deploy.yml

And here`s the error action in build: https://github.com/amestofortytwo/blog/actions/runs/4143997258

remiks commented 1 year ago

Alright. Got it to build now! The issue was that I had two blogpost that was missing any of H1/2/3/4/5 tag. Added h1tag and the problem was gone. Maybe you should have an error handling if there is any post that are missing it?

daiyanze commented 1 year ago

I see. The "table of content" didn't add default input items data which lead the type error.

Have to say I didn't expect my articles to have no heading tags. But TBH, it's a careless mistake here. Apologies for that

daiyanze commented 1 year ago

Hi @remiks! I made a beta release just now and hope the issue is gone. You could also check the following page for a quick confirmation. https://pitayan.github.io/gatsby-theme-pitayan/posts/no-heading-post/

daiyanze commented 1 year ago

Hello @remiks! Here's a small reminder.

FYI, I'd like to release this one soon (probably within today).