search

PitchBlackRecoveryProject / android_bootable_recovery

The heart :heart: of PBRP
https://pitchblackrecovery.com
Apache License 2.0
102 stars 40 forks source link

Ameliorate English strings #65

Closed LinkBoi00 closed 3 years ago

LinkBoi00 commented 3 years ago

We Merge Pull Requests Submitted Here After Reviewed By Core Developers

If you are submitting any patches, Tell us a little about it.

Fixes:

Improvements:

Kindly wait for Core Developers to review.

You can join our community on Telegram

manjotsidhu commented 3 years ago

@LinkBoi00 Can you send screenshot of the home screen with these changes ?

LinkBoi00 commented 3 years ago

@LinkBoi00 Can you send screenshot of the home screen with these changes ?

Sure Screenshot_PBRP_2021-01-15-00-00-50 Screenshot_PBRP_2021-01-15-00-00-55 Screenshot_PBRP_2021-01-15-00-01-02

LinkBoi00 commented 3 years ago

@LinkBoi00

?

DelightReza commented 3 years ago

@LinkBoi00 Can you send screenshot of the home screen with these changes ?

Sure Screenshot_PBRP_2021-01-15-00-00-50 Screenshot_PBRP_2021-01-15-00-00-55 Screenshot_PBRP_2021-01-15-00-01-02

There should be Install ROM/Install Patches (Modify ROM)

LinkBoi00 commented 3 years ago

@LinkBoi00 Can you send screenshot of the home screen with these changes ?

Sure Screenshot_PBRP_2021-01-15-00-00-50 Screenshot_PBRP_2021-01-15-00-00-55 Screenshot_PBRP_2021-01-15-00-01-02

There should be Install ROM/Install Patches (Modify ROM)

Is something like: Install ROM or make modifications to the installed ROM (in 2 lines) fine? (Maybe that won't fit, I'll work on it later today)

LinkBoi00 commented 3 years ago

Screenshot_PBRP_2021-01-15-05-48-07 1

@md-raza I think that addresses your feedback. The previous string indicated that you cannot flash a new ROM, only make modifications to the existing one. I think that's fixed now

LinkBoi00 commented 3 years ago

Also corrected a wrong capitalization in "Enable dmesg logging after flash" (F was capital)

LinkBoi00 commented 3 years ago

@manjotsidhu Here's the final look of the home screen, adressing @md-raza 's feedback

Screenshot_PBRP_2021-01-15-05-48-07 1

@md-raza I think that addresses your feedback. The previous string indicated that you cannot flash a new ROM, only make modifications to the existing one. I think that's fixed now

So @manjotsidhu here's the final look of the home screen

manjotsidhu commented 3 years ago

Screenshot_PBRP_2021-01-15-05-48-07 1

@md-raza I think that addresses your feedback. The previous string indicated that you cannot flash a new ROM, only make modifications to the existing one. I think that's fixed now

Actually the previous strings were made by @AndroiableDroid and he specifically made it to be in slang language. I don't know which is better. Would be needing community's feedback on this.

LinkBoi00 commented 3 years ago

Screenshot_PBRP_2021-01-15-05-48-07 1 @md-raza I think that addresses your feedback. The previous string indicated that you cannot flash a new ROM, only make modifications to the existing one. I think that's fixed now

Actually the previous strings were made by @AndroiableDroid and he specifically made it to be in slang language. I don't know which is better. Would be needing community's feedback on this.

The thing is, that the language was inconsistent (for example, wrong capitalizations) and sometimes it was really not understandable, but sure, no problem. Thanks

manjotsidhu commented 3 years ago

Lets discuss on https://github.com/PitchBlackRecoveryProject/android_bootable_recovery/discussions/66

manjotsidhu commented 3 years ago

Lets discuss on #66

Looks like we have got sufficient feedback on it. @LinkBoi00 just need to change Advanced Card string to "More options for advanced users" and then we are good to go.

AndroiableDroid commented 3 years ago

@manjotsidhu LGTM

LinkBoi00 commented 3 years ago

Lets discuss on #66

Looks like we have got sufficient feedback on it. @LinkBoi00 just need to change Advanced Card string to "More options for advanced users" and then we are good to go.

Alright, will do soon, thanks

LinkBoi00 commented 3 years ago

It looks a bit empty w/o the second "more", maybe I will have to put something else in its place

LinkBoi00 commented 3 years ago

@manjotsidhu Force pushed again, addressing your feedback

LinkBoi00 commented 3 years ago

Also, I changed this string: pb_dmverity_chk, since, I think it's more understandable now

manjotsidhu commented 3 years ago

@AndroiableDroid once review for the final time.

imranpopz commented 3 years ago

Screenshot_PBRP_2021-01-15-05-48-07 1 @md-raza I think that addresses your feedback. The previous string indicated that you cannot flash a new ROM, only make modifications to the existing one. I think that's fixed now

Actually the previous strings were made by @AndroiableDroid and he specifically made it to be in slang language. I don't know which is better. Would be needing community's feedback on this.

The thing is, that the language was inconsistent (for example, wrong capitalizations) and sometimes it was really not understandable, but sure, no problem. Thanks

Is this the final homescreen ?

manjotsidhu commented 3 years ago

Almost, there is a small change in Advanced Card string

imranpopz commented 3 years ago

Almost, there is a small change in Advanced Card string

Yup " More options for advanced users " suits better

manjotsidhu commented 3 years ago

@LinkBoi00 can you make PR for android-10.0 branch as well ?

LinkBoi00 commented 3 years ago

@LinkBoi00 can you make PR for android-10.0 branch as well ?

sure