search

PitchInteractiveInc / Phinch

Phinch is an open-source framework for visualizing biological data, funded by a grant from the Alfred P. Sloan foundation. This project represents an interdisciplinary collaboration between Pitch Interactive, a data visualization studio in Oakland, CA, and biological researchers at UC Riverside.
http://phinch.org/
BSD 2-Clause "Simplified" License
149 stars 30 forks source link

Why is Phinch limited to Chrome Browser? #57

Open iimog opened 8 years ago

iimog commented 8 years ago

I wondered why Phinch is limited to Chrome Browser? For testing I downloaded and installed Phinch locally. After applying the fix in #49 and adding Firefox to the list of allowed userAgents I was able to visualize my biom files. I found no obvious problems with Firefox in comparison to Chrome. Are there specific things I can look at? Otherwise the restriction to Chrome might be outdated and can be removed?

hollybik commented 8 years ago

We optimized Phinch for use with Google Chrome, and that is the browser we recommend for users accessing the public web implementation at http://phinch.org - but in reality the codebase is designed to work with all modern browsers. We haven't extensively tested across browsers yet (since there may be slight variations in the underlying javascript library paths), but glad to hear that you were able to find a fix for Firefox and get Phinch working!

iimog commented 8 years ago

Thanks for the explanation. For me this issue is resolved and can be closed. Just a short note: The Browser Support section in the wiki (https://github.com/PitchInteractiveInc/Phinch/wiki#browser-support) might be slightly misleading:

Phinch supports so-called “modern” browsers, which generally means everything except IE8 and below. D3 is tested against Firefox, Chrome (Chromium), Safari (WebKit), and Opera. Parts of Phinch may work in older browsers. You'll need a modern browser to use SVG and CSS3 Transitions.

While this is generally true, the current version of Phinch explicitly blocks all other browsers than Chrome.