search

Pithikos / python-websocket-server

A simple fully working websocket-server in Python with no external dependencies
MIT License
1.14k stars 384 forks source link

Add minimum python version in setup.py #93

Closed Lothiraldan closed 2 years ago

Lothiraldan commented 3 years ago

It looks like latest released version don't support Python 3.5 anymore. It is failing on line https://github.com/Pithikos/python-websocket-server/blob/master/websocket_server/websocket_server.py#L296 because it is using a f-string which is only available in Python 3.6+.

If it was intentional, this PR is adding the correct package metadata so pip can choose the right version depending on the user Python Version.

Pithikos commented 2 years ago

Good catch. Thank you!