Context Menu Search bug (Version 0.9.0)

[haitham506]

Hello,

After the extension updated to version 0.9.0, the Context Menu search is not working correctly you have to click the search engine twice for it to work, the first click does nothing.

Thank you 👍

[MateoGrande]

I concur. It's like clockwork. You have to right click, then click the search option (nothing happens), then repeat those steps to get it to search. Other default right click menu features are not affected. I have the following other extensions installed in case there's a conflict:

• DealerInspire Conversations - Notifications
• Google Docs Offline
• Highlight Magic
• Previous Tab
• Reader View
• Text Blaze: Templates and Snippets
• uBlock Origin

[Pitmairen]

What browser are you using?

I can't reproduce the need for a two clicks to open the search in Chrome.

But there are some issues with the context menu, as it is throwing errors in the console because of some problems when configuring the context menu, so that is probably related.

I'm trying to find a way to solve this. The behavior when setting up the context menu has changed when the extension was upgraded to use manifest version 3, so I probably have to rewrite some of the logic.

[haitham506]

Both Edge and Chrome have the same issue.

After the second click it will work fine for a short time and then it happens again after.

• The issue occurs in regular search and incognito search too.

Here is a recording for the issue:

https://github.com/Pitmairen/selection-search/assets/66400184/7780533b-4956-4b95-82ca-a403c425d987

[Pitmairen]

Then it is most likely related to how Chrome (and probably other browsers) now puts the background worker of the extension into sleep state from time to time.

So if the worker is sleeping, the first click wakes up the worker, but the worker isn't ready yet to handle the click. Then on the second click the worker is ready and handles the click.

I think I know how to fix your problem, but there are still some other issues that needs fixing before I can make a new release.

[Pitmairen]

I have submitted version 0.9.1 with some fixes. I believe it should fix your issue.

The release must be reviewed by google first, so it may take a day or so before it is available.

It has been set to roll out only to 20% of existing users, which was also the case for 0.9.0, so you may not be auto updated if you are not selected.

[haitham506]

Just got the 0.9.1 Update, It is working perfectly now 👍

Thank you :)

[Pitmairen]

Great!

On Wed, May 8, 2024, 15:44 haitham @.***> wrote:

Just got the 0.9.1 Update, It is working perfectly now 👍

Thank you :)

— Reply to this email directly, view it on GitHub https://github.com/Pitmairen/selection-search/issues/153#issuecomment-2100612228, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACXFKC7QXWI47U5PSBZFU3ZBIT2PAVCNFSM6AAAAABHGZQXUCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBQGYYTEMRSHA . You are receiving this because you commented.Message ID: @.***>