search

Pitmairen / selection-search

Search extension for the chrome web browser
GNU General Public License v3.0
188 stars 26 forks source link

Firefox ESR 60 compatibility #53

Open ribatamu opened 5 years ago

ribatamu commented 5 years ago

Please, can you make Selection Search compatible with Firofox ESR 60?

Pitmairen commented 5 years ago

It should already be compatible, but for versions that is based on firefox before version 63, the shadow DOM functionality is disabled by default. The extension still works without this, but the popup style/layout can be affected by the styling on the page and make it look weird.

From firefox 59, shadow dom can be enabled by opening about:config and setting: dom.webcomponents.shadowdom.enabled = true. In firefox 63 this setting is true by default.

If you enable the config value the extension should work in Firefox ESR 60.

But because shadow dom is not enabled by default in version older that 63, I have set version 63 as the minimum version required to be able to install from the addons page.

You can download the source from the https://github.com/Pitmairen/selection-search/tree/firefox-web-extension branch and modify the manifest.json file and modify the strict_min_version to be 60 and then load it from the about:debugging page.

I think it is also possible to create a file that can be installed so that it will work as a regular extension: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Distribution_options/Sideloading_add-ons