search

Pitmairen / selection-search

Search extension for the chrome web browser
GNU General Public License v3.0
189 stars 26 forks source link

Blacklist doesn't work on google books built-in webreader page #58

Open Dexcn opened 5 years ago

Dexcn commented 5 years ago

So when you log in google books(https://play.google.com/books) and click one of your books to read online (books are either purchased or uploaded from pc, epub books), the url would be like this:https://play.google.com/books/reader?id=_xxxxxx&pg=GBS.PA5。

And I put "play.google.com" or "play.google.com/books" in the blacklist and save. It doesn't work. It does work on the main page of play.google.com though, just not the online ebook reader page.

Windows 10, the lastes version of Centbrowser(based on chromium)

Pitmairen commented 5 years ago

Try this url instead:

books.googleusercontent.com

Parts of that page seems to be loaded through an iframe, which loads the content from a different url than the one shown in the address bar.

But it looks like there is another bug with how the blacklist is saved. I just noticed that when adding a new url to the blacklist, I had to save the options page twice before the new url in the blacklist was activated.

A temporary fix is just to add the new url to the blacklist and save. Then just change an arbitrary option to enable the save button again and save, change the option back to the previous value and save. This should make the new url in the blacklist load correctly.

I will try to fix this bug soon.

Dexcn commented 5 years ago

Thanks a lot, Pitmairen! Works like a charm!