Legacy mode bug on Android 14 with music player apps - Githubissues

Pittvandewitt / Wavelet

A quick rundown on each feature and its settings

https://pittvandewitt.github.io/Wavelet/

622 stars 35 forks source link

Legacy mode bug on Android 14 with music player apps #269

Open shsui5379 opened 9 months ago

shsui5379 commented 9 months ago

After updating to Android 14 (Pixel Oct. 2023 stable), when legacy mode is enabled, when you start playback on a music player app (ex: Spotify, Tidal, YouTube Music, etc.), no audible sounds are outputted until you turn Wavelet off then on again.

Specifically affecting playback over USB Audio.

acarasimon96 commented 7 months ago

Can confirm this myself on Pixel 7a with the latest security updates and Bluetooth audio. I've never had this happen before I updated my system to Android 14 last October.

Pittvandewitt commented 7 months ago

Does this issue persist using the update released in the beta test?

acarasimon96 commented 7 months ago

Yes, the bug still exists in beta v23.11

acarasimon96 commented 7 months ago

I'd like to add that I can't reproduce this on speaker output if no other audio device is connected to my phone

Pittvandewitt commented 7 months ago

This leads me to believe that the file where the settings are stored from and read to is not correctly synced to the settings you see on your screen when switching from an output device, but this doesn't necessarily have to do with legacy mode. I'll have to rewrite a tiny bit of code to make sure this doesn't happen anymore.

Pittvandewitt commented 7 months ago

Possible duplicate of https://github.com/Pittvandewitt/Wavelet/issues/251

acarasimon96 commented 7 months ago

I don't think it has to do with just switching devices. As stated in earlier comments, this is reproducible during and after connecting the audio device.

However, that doesn't rule out the possibility that it's some sort of settings-related bug that only affects Android 14 users who have Legacy Mode enabled.

Pittvandewitt commented 7 months ago

Just to make sure, is there no audible sound or are the changes made by Wavelet not applied to the music?

acarasimon96 commented 7 months ago

No sound only when Wavelet is already turned on and either the following happens:

An audio device (Bluetooth or USB) is connected while there is already something playing audio
I start playback while an audio device is connected and after nothing has been playing for at least a few seconds

Again, turning off Wavelet and turning it back on while audio is already playing causes the DSP to work again. The same workaround can be achieved with toggling Legacy Mode off and back on, but then I have to do either workaround again the every single time I start playing music again.

Pittvandewitt commented 7 months ago

I was able to reproduce the issue only a handful of times. I think legacy mode is showing its age after 12 years. Do you have virtualisation enabled?

acarasimon96 commented 7 months ago

Virtualization was turned off when I tested for the bug earlier, and I don't see an option for it when Legacy Mode is enabled (which is expected according to the docs, I think).

Pittvandewitt commented 7 months ago

Virtualization was turned off when I tested for the bug earlier, and I don't see an option for it when Legacy Mode is enabled (which is expected according to the docs, I think).

Reverberation is not available in legacy mode, but virtualisation is. Are you sure virtualisation was off or are you confusing it with reverberation?

acarasimon96 commented 7 months ago

Oh, my bad. It was on actually, but I just tested Wavelet again with Virtualizer off and I was able to hear sound when I started playback with Legacy Mode turned on.

I swear I left that feature enabled back when I had Android 13 and never encountered the bug in that Android version.