Piwigo / Piwigo-Android

Piwigo Native Android App
GNU General Public License v3.0
140 stars 43 forks source link

Added the ability to create some albums from the app #105

Closed Valou447 closed 5 years ago

Valou447 commented 5 years ago

I created a new Service called "AlbumService" to handle album creation. It may be reused for renaming, deleting, and moving album in the future.

It is for now just a button in the drawer, but it could also be added into a FAB context menu.. (see issue #104)

The only problem for now is the album list is not refreshing, something which should be reviewed in another issue..

Thank you :)

ramack commented 5 years ago

did you forget to commit your strings.xml? - for sure only the English one, without language code extension..

ramack commented 5 years ago

The toast you show now on the failure is probably not helping the user a lot. Maybe we should add a generic snackbar for such cases, that states the failure (as currently your toast) but additionally provides a button 'details' which show the complete exception and there a button 'report', that uses ACRA to send a crash report email to us... but this would be too much for this PR. We should do it on a separate ticket...