Piwigo / Piwigo-Android

Piwigo Native Android App
GNU General Public License v3.0
141 stars 43 forks source link

update images in app store #136

Closed ramack closed 4 years ago

ramack commented 4 years ago

We have updated the graphics to fit the new Piwigo styling within the app. Accordingly we shall update the app store listing graphics in listings.

Preferably for sure even with screenshots for each language. Maybe we can setup the jenkins server to generate screenshots for each language and push them to a new branch with a PR?

@voriondev you are close to the piwigo styling team, can you take care about this?

Valou447 commented 4 years ago

I agree that we need to upgrade the screenshots because we did a lot of changes in the UI in itself.

But is it relevant to setup a Jenkins task for such purpose when we are not going to change the UI so much in each subversion ?

What are your thoughts @plegall ?

ramack commented 4 years ago

The nice.thing with Jenkins generating screenshots would be the easy going to have localized screenshots. And new languages will come!

Valou447 commented 4 years ago

Done in #151

ramack commented 4 years ago

Sorry @voriondev I have to reopen this ticket... I recognized, that we need:

Sorry for not detecting this during the review where you asked, but only now...

Valou447 commented 4 years ago

Everything should have the .jpg format then ?

ramack commented 4 years ago

For sure not. JPEG and its compression algorithm will make the edges in logos look weird PNG ia the good format for logo and featuregraphic just with a nontransparent background and the needed sizes.

Valou447 commented 4 years ago

What background color is needed then ? I did refer to the old graphics and favicon and they used to have transparent background..

I don't really get how it works :(

ramack commented 4 years ago

quote from https://developer.android.com/google-play/resources/icon-design-specifications "If possible, pick a background color for your asset that's appropriate for your brand and doesn't include any transparency. Transparent assets will display the background color of Google Play UI."

So I think the best would be to just fill the background with the white that is used already in the symbol...

I'll commit it.