Added sample details for login issues

Piwigo / Piwigo-Android

Piwigo Native Android App

GNU General Public License v3.0

140 stars 43 forks source link

Added sample details for login issues #142

Closed Valou447 closed 5 years ago

Valou447 commented 5 years ago

Just added a "show details" action to the already existing Snackbar. It shows a short description of what the issue is.

For example:

Login failed = Invalid credentials

Handshake failed = Invalid SSL cert

Attempt to read from field 'boolean org.piwigo.io.model.SuccessResponse.result' on a null object reference = Not a Piwigo server

Valou447 commented 5 years ago

We are displaying errors that are not very understable for a standard user. This is for development purpose and should be gone once we are able to determine all the error cases and just show a more precise error for the user without getting into code and stacktrace..

ramack commented 5 years ago

But that is why we don't show it directly and only with a show details...

Valou447 commented 5 years ago

Sure, but to me it is still too « technical » for a user.. if we keep it, we do need to make it easy to understand then.

Anyway, let’s go on !