Piwigo / Piwigo-Android

Piwigo Native Android App

GNU General Public License v3.0

141 stars 43 forks source link

uploading fails sometimes (= if file is bigger than upload_max_filesize in php.ini) #158

Closed ramack closed 4 years ago

ramack commented 4 years ago

Describe the bug and how to reproduce For some photos I get after upload: upload failed without further details.

I tried with a Photo which had a space in the name, but I am not yet sure whether this us related.

Expected behavior All photos shall be uploadable. And if the upload fails I expect to ge a reason why it failed, just "upload failed" is too fuzzy, as it doesn't allow the user to understand whats wrong and fix or workaround it.

ramack commented 4 years ago

126 was the cause in my case. The upload_max_filesize (in php.ini) was still on its default of 2M (megabytes), and I tried with a bigger file.

So we leave this behavior for 1.0.0 and add chunk-support in 1.1.0, but improving the error message would really be good.

ramack commented 4 years ago

closed in #162 but the error details are not very helpful, as piwigo server's output isn't, see https://github.com/Piwigo/Piwigo/issues/1105 also in #161 we'll improve the messaging system