Piwigo / Piwigo-Android

Piwigo Native Android App

GNU General Public License v3.0

140 stars 43 forks source link

WIP #179 #181

Closed Valou447 closed 4 years ago

Valou447 commented 4 years ago

Should fix the "crash" issue caused by an empty response.body().

@ramack Is there something to add ? An explanation to the user or anything ?

ramack commented 4 years ago

Solves #180 I wonder whether a user would understand the error message... Do we output 'no piwigo installation found at assess...'?

Valou447 commented 4 years ago

We do display such a message "No Piwigo Server found at such address", but sometimes it goes for unparsable JSON.. I don't really get why tho.

ramack commented 4 years ago

as documented in the issues, I think this is not a bug and we should not merge any such check, as the code behaves as expected, just the reporting would need improvement.

If nobody objects I'd close this in a few days without merging.

Valou447 commented 4 years ago

@ramack This is a bug as the app is crashing when the response body is empty.

179 is crashing where #180 needs a improvement on reporting.