Piwigo / Piwigo-Android

Piwigo Native Android App
GNU General Public License v3.0
140 stars 43 forks source link

Zoom and slide do not mix well #186

Closed dkm closed 4 years ago

dkm commented 4 years ago

When displaying a picture:

I'm using a Fairphone 2 with android 7 and testing the app from f-droid install 1.0.2

ramack commented 4 years ago

Thanks for the report, we have to look into this in detail. I just tried and I did not even manage to zoom anywhere but in the center of the photo, and I do not manage to "move" inside the picture, but always get a slide towards the next photo. @voriondev can you look into this, as you know that code best?

jeff-amn commented 4 years ago

@ramack I have also noticed this. I found that if you move up or down and also move left or right you can move around the zoomed image. Seems like the move left or right needs to check to see if the image is in the zoomed state or not.

ramack commented 4 years ago

Ah yes. The "pure" left and right slide is directly changing images, while any other direction is moving inside the photo...

dkm commented 4 years ago

Nice catch ! I would still tag as a bug instead of enhancement, but as long as it's fixed... ;)

Valou447 commented 4 years ago

I've figured out how to fix this, anyway in terms of usability, should I allow user to slide between pictures even if the image is lightly zoomed, or should the zoom be null before letting the user jump to the next image ?

dkm commented 4 years ago

Usually, you slide to the next when you slide out of the picture. So, yes, I would favor for being able to slide to the next picture even when zoomed-in.

dkm commented 4 years ago

(I think you should mimic what regular gallery app are doing)