search

Piwigo / Piwigo-Android

Piwigo Native Android App
GNU General Public License v3.0
140 stars 43 forks source link

Double tap to zoom #188

Closed dkm closed 3 years ago

dkm commented 4 years ago

That's a very common UI gesture: double tap zooms in the picture being displayed. Would be nice to have it !

ramack commented 4 years ago

I fully agree, we should have that! But with the given workload, I think we should postpone it to maybe release 1.3. Not that this is unimportant, but the others open issues are of higher priority in my eyes.

What do you think?

Side note: for sure if someone is ready to submit a PR we will include it earlier!

dkm commented 4 years ago

Sure, that's not high prio :) I simply checked it was not already logged somewhere and opened the issue. That can be a low hanging fruit in terms of new feature (f-e for new contribution).

mrufflesmcghie commented 4 years ago

I think I have a solution to this, just downloading android studio & will have a play later. Obv as said previous am new to this so will be trial n error if I have a good result I'll let you know :-) Something like this...

ramack commented 4 years ago

No problem, any help is welcome. So just ensure that you don't submit code copyrighted by other authors. - Which doesn't mean you cannot copy paste some code or take inspirations from public things, but don just copy-paste substantial parts.

For the technical stuff for sure we will review and guide you, so it is good to start with a small thing for contribution and get used to the workflow and the current code base, as it has quite some learning curve :-)

dkm commented 3 years ago

safe to say this can be closed :)